Squarespace / datasheets

96%

master: 96%

LAST BUILD ON BRANCH zcm/switch_coveralls_image_url

branch: zcm/switch_coveralls_image_url

CHANGE BRANCH

x

Reset

• zcm/switch_coveralls_image_url
• 0.1.3
• 0.2.0
• 0.3.0
• 5-switch-to-google-auth
• master
• prod_master

Build # 53

Build Type

Pull #10

travis-ci

Committed by web-flow

Commit Message

Add query param to get around Github cache issue

Github caches resources. This causes issues with badges. The specific
example here was a Coveralls result saying we have 0% test coverage,
which then became the cached badge result for our README page. Even
though we re-ran Travis to get the correct code coverage amount (96%),
we can't get the 0% badge to go away, even when clearing the local
browser cache. Again, this is because it is actually Github itself that
is caching the resources. According to the Coveralls issue below, one
solution is to use query string params. Even with static query string
parameters, there is a tendency for them to invalidate cache resources,
so we'll give that a shot.

This will likely work in the short-term regardless: this is a different
resource URL so Github's cache will be invalid. As a result, we won't
actually know if this solves the real issue until a similar situation
arises in the future.

Issue mentioned above:
    https://github.com/lemurheavy/coveralls-public/issues/971

Pull Request Pull Request #10: Add query param to get around Github cache issue

Run Details

480 of 502 relevant lines covered (95.62%)

1.91 hits per line