SpiNNakerManchester / SpiNNMan

64%

master: 67%

LAST BUILD ON BRANCH bugfix/get-machine-process-column-reordering

branch: bugfix/get-machine-process-column-reordering

CHANGE BRANCH

x

Reset

• bugfix/get-machine-process-column-reordering
• 1!7.0.0
• 3.10
• 5.1.0
• 7.0.0
• 7.0.0-a1
• 7.0.0-a5
• 7.0.0-a6
• 7.0.0.a5
• 7.1.0
• AbstractContextManager
• Compressor_error
• DeprecationWarning
• Fix_error_on_run_after_reset
• Fix_locate_connected_machine
• HEAD
• MOAR-tests
• Transceiver_not_a_ContextManager
• UnusedVariable
• W605
• abstract-context-manager
• actions1
• add_link_to_info
• add_memory_file_interface
• alan-stokes-patch-1
• all_algorithms
• all_algorithms_v2
• allow_count_p2p_timeout
• allow_noreply_to_count
• apache
• apache2
• app-notes
• auto_excludes
• avoid_whole_board_skips
• better_board_testing
• better_error
• better_error_on_exec
• better_flake8
• better_log
• better_sdp_handling
• better_spalloc_login_error
• better_timeout
• bmp_names
• boot_port_no
• breakout_neuromodulation
• bugs_found_by_mypy
• bump6.0.1
• bye_bye_six
• c_version_of_router_compressor_with_bit_field
• catch_os_error_on_send
• cfg_lower
• cfg_stack
• check_error_cores
• check_fixed
• check_unidir_links
• checkout
• chip_big
• chip_test
• citation
• citation_plus
• classifiers
• clear_router_diagnostic_counters
• config2
• config3
• config_to_shut_up_debug
• context
• cores_in_state
• coverage
• coverage4
• cpu_info
• cpu_infos
• create_transceiver
• cull-duplicates
• cyclic_stdp_pynn9
• defaults_from_cfg
• delays
• dependabot/github_actions/actions/checkout-4
• dependabot/github_actions/actions/setup-python-5
• deprecate
• detect-closed-sockets
• detect_router_errors
• dict
• different_app_loading
• dma_caching
• dnn_conversion
• doc-cleanup
• doc-fix
• doc-polish
• doc-tweak
• doc-xref
• doc_fix
• dont_swallow_callback_errors
• emergency_routing
• end-27
• ensure_board_is_ready
• eprop_adaptive
• eprop_adaptive_update
• erbp
• error_update
• extended
• extra_logging
• fewer_timeouts
• first_dates
• fix-sphinx-properly
• fix-to_data_in_protocol
• fix_bmp_conenctions
• fix_connection_selection
• fix_copy_run_0_0
• fix_copy_run_again
• fix_error_cores
• fix_ethernet_ip_address
• fix_flood_fill
• fix_for_armcc
• fix_get_cores_in_run_state
• fix_get_cores_in_state
• fix_ignore_bad_ethernet
• fix_msg_size
• fix_multiboard_ethernet
• fix_oops
• fix_p2p_busy_wait
• fix_potential_sdp_loophole
• fix_proxy_listening
• fix_retries
• fix_router_diagnostics
• fix_scamp_arp
• fix_sdp_mixup
• fix_stack_overflow
• fixes-from-java-code-review
• fixy_fixy_for_donal
• fpga_check_update
• g35
• gb_cls
• gd_ro
• get_clock_drift
• get_iobuf_even_with_errors
• get_machine
• get_status_string
• github-job-timeouts
• global_data3
• global_data4
• global_data5
• global_data6
• global_data7
• global_data_new
• grouped-exceptions
• heat_demo
• hide_transceiver
• hole
• http
• https
• icub_vor
• icub_vor_update
• ignore_ethernets
• import_all_fix
• improve_flood_fill
• improve_get_cores_in_run_state
• increase_retry
• int_sdram
• ip_address_error_message
• is_config_none
• java_json
• jenkins
• jenkins2
• jenkins_fix
• keep_alive
• lag_reporter
• link_test
• list-wanted
• load_application
• log_fix
• log_spalloc_operation
• logger_string_fix
• lost_spike_issues
• master
• max_cores_per_chip
• minor-import-improvements
• mobilenet_experiments
• mock
• mon_delegate_0_0
• more-utils
• more_error_details
• move_ExecutableType
• multicompartment_Bern
• no-more-storage-handlers
• no-p2pc-command
• no-space-check
• no3.7
• no_frame
• no_frame2
• no_frames3
• no_max
• no_virtual_chips
• not_abc
• nothing_to_run
• nuke_memory_io
• number_of_boards
• numpy-version-redux
• numpy_from_utils
• numpy_requirement
• on_workflow
• overrides_check
• p2p_ping
• p2p_ping_2
• p3_fix
• p_list
• pair_compressor
• pair_untangle
• pallel_java
• paper_tests
• port_trigger
• power_on_during_init
• project_eighteen
• proper_fix
• proper_reboot_wait
• proxy-upgrade
• push_bot_viewer
• py3
• py3.7
• py38
• py3_bytestring_database_fix
• pylint
• pylint2.16.5
• pylint_default
• pylint_fix
• pylint_fixes
• pylint_strict
• pyproject.toml
• python3.11
• python3.12
• quick-tests-refactor
• quick_test
• quota
• range_compress
• rat
• rationalise-eieio
• read-arrays-in-SVs
• read_machine_progress
• read_user_0
• read_word
• readthedocs.yaml
• reduce-op-complexity
• reduce_cores_hack
• reduce_overhead
• reduce_overhead_cb
• redundant_params
• release-6.0.0
• release_5.0.0
• release_5.1.0
• remove-dead-classes
• remove_18
• remove_quick_tests
• remove_with_in_tests
• requirements
• resource-handling-fix
• retry_copy_run_load
• reuse_processor
• roc3
• roc_part
• rt_entry
• run_progress
• scamp_3.4.0_release
• scamp_arp_fix
• scamp_boot_from_luis
• scp_data_type
• sdram_retry_fix
• send_chip_update_provenance_and_exit
• send_scp_message
• setup-action-man
• simplify_cpu_infos
• simplify_data_in
• single_routing_entry
• small_placer
• spalloc-server
• spalloc-server-jdbc
• spalloc_client
• spalloc_server_jdbc
• speed_up_data_in
• speed_up_data_out
• speelign-and-other-minor-fixes
• sphinx-version
• spif_output
• spin4
• spin_1_or_2
• spinnaker_start
• spinnaker_tools_3.3.0
• spinncer
• spinncer_update
• spinnman_integration_tests
• split_processors
• stable_time_sync
• state_notification
• states_with_cores
• stop_double_count
• store_v_to_p_map
• str_fix
• struct_pl_merger
• temp
• tempo
• test
• test_3_9
• test_objects
• tester
• tidy
• tidy-eieio-listener
• timer_sync
• too_big_too_place
• transceiver-tinkering
• transceiver_by_version
• transceiver_do_we_need
• transceiver_fixes
• turn_off_machine
• unique_json
• unittest_setup
• unreachable_chips
• untangle
• update_provenance_and_exit
• update_scamp_boot
• update_version
• upgrade_travis_dist_to_bionic
• use-real-port-in-board-test-config
• use-right-token
• use-supported-thread-pool
• use_all_connections
• use_build
• user3
• users
• v_to_p_map
• version
• version2
• version248
• version_bump
• version_fix
• warning
• where_is_chip
• whole
• with2
• with3
• with_database
• wrapped2
• wrapped_machine
• wrapped_rig
• zero_cabinet_and_frame

Build # 1259

Build Type

Pull #141

travis-ci

Committed by web-flow

Commit Message

Fix long-standing bug in SpiNNMan with packet reordering

The reading of the P2P table data within GetMachineProcess was wrong, in
that it could reorder the columns of table data. That only occurred when
the reading of one column gets delayed (because of the need to resend a
packet) and the reading of the column after it works immediately,
allowing the results to slip past each other. This would result in them
being entered into the host-side raw P2P table data array in the wrong
order, which in turn would corrupt the building of the parsed P2P table.

Fortunately this is a very rare occurrence in the Python code as the
language is so slow that multiple packets in flight are hardly ever
launched in practice, but it is a bug that is fixed by binding where to
store in the table (known at packet dispatch time!) into the response
callback.

Pull Request Pull Request #141: Fix long-standing bug in SpiNNMan with packet reordering

Run Details

4 of 4 new or added lines in 1 file covered. (100.0%)

3691 of 5756 relevant lines covered (64.12%)

1.28 hits per line