SAP / sqlalchemy-hana
96%
main: 95%

LAST BUILD BRANCH: renovate/lock-file-maintenance
DEFAULT BRANCH: main
Repo Added
Files 23
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH step-461
branch: step-461
CHANGE BRANCH
x

coverage: 95.816% (+8.3%) from 87.487%
29399238210

push

github

web-flow 
Fix sql.false()/sql.true() rendering under use_native_boolean=False (#656)

## Summary

`HANAStatementCompiler.visit_is_true_unary_operator` and
`visit_is_false_unary_operator` unconditionally emit `... = TRUE` /
`... = FALSE`. When the dialect is configured with
`use_native_boolean=False`, SQLAlchemy's base `visit_true`/`visit_false`
render the wrapped element as an INT literal (`1`/`0`), so the compiled
WHERE becomes e.g. `WHERE 0 = TRUE` — which HANA rejects with error
**266 "BOOLEAN type is not comparable with INT"**.

This PR makes both overrides branch on
`self.dialect.supports_native_boolean` and fall back to an INT compare
in non-native mode. Native-mode behaviour is unchanged: the existing
`= TRUE` / `= FALSE` path is preserved, which is why these overrides
exist in the first place (HANA rejects a bare `WHERE TRUE` /
`WHERE FALSE`, per the comment above the methods).

## Reproducer

```python
from sqlalchemy import literal_column, select, sql
from sqlalchemy_hana.dialect import HANAHDBCLIDialect

dialect = HANAHDBCLIDialect(use_native_boolean=False)
stmt = select(literal_column("id")).where(sql.false())
print(stmt.compile(dialect=dialect))
# Before this PR:  SELECT id FROM DUMMY WHERE 0 = TRUE   <-- HANA error 266
# After this PR:   SELECT id FROM DUMMY WHERE 0 = 1
```

## Before / After

`select(literal_column("id")).where(sql.false())` with
`use_native_boolean=False`:

| | Before | After |
| -------------- | -------------------- |
---------------------------------- |
| Compiled SQL | `WHERE 0 = TRUE` | `WHERE 0 = 1` |
| HANA response | error 266 | executes; predicate is always false |

Same statement with `use_native_boolean=True` (unchanged):

|                | Before                 | After                  |
| -------------- | ---------------------- | ---------------------- |
| Compiled SQL   | `WHERE false = TRUE`   | `WHERE false = TRUE`   |

## Test evidence

Added `test_sql_unary_boolean_non_native` in `test/test_sql_compile.py`
tha... (continued)

10 of 11 new or added lines in 2 files covered. (90.91%)

13 existing lines in 1 file now uncovered.

1855 of 1936 relevant lines covered (95.82%)

0.96 hits per line

Relevant lines Covered
1936 RELEVANT LINES 1855 COVERED LINES
0.96 HITS PER LINE
Source Files on step-461

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
29399238210 step-461 Fix sql.false()/sql.true() rendering under use_native_boolean=False (#656) ## Summary `HANAStatementCompiler.visit_is_true_unary_operator` and `visit_is_false_unary_operator` unconditionally emit `... = TRUE` / `... = FALSE`. When the dialect is... push web-flow github
95.82
29398684632 step-461 Fix sql.false()/sql.true() rendering under use_native_boolean=False (#656) ## Summary `HANAStatementCompiler.visit_is_true_unary_operator` and `visit_is_false_unary_operator` unconditionally emit `... = TRUE` / `... = FALSE`. When the dialect is... push web-flow github
95.82
See All Builds (324)