Qiskit-Extensions / qiskit-experiments
88%
main: 88%

LAST BUILD BRANCH: gh-readonly-queue/main/pr-1267-60655bb7aa78fd8f27a3a0be3c19f1e89e483305
DEFAULT BRANCH: main
Repo Added
Files 168
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH gh-readonly-queue/main/pr-1252-1acc02d49d7c8baaae3f495af049b58f24a8d0c3
branch: gh-readonly-queue/main/pr-1252-1acc02d49d7c8baaae3f495af049b58f24a8d0c3
CHANGE BRANCH
x

coverage: 88.281% (-0.001%) from 88.282%
6009595088

push

github

web-flow 
Reimplement AnalysisResultTable (#1252)

### Summary

Follow-up of #1133 for data frame. 

### Details and comments

I realized I had some mistake when I wrote a base class of
`ThreadSafeDataFrame`. We plan to move the curve data (XY data) to the
artifact for better reusability of the data points. In addition,
[CurveData](https://github.com/Qiskit-Extensions/qiskit-experiments/blob/c66034c90/qiskit_experiments/curve_analysis/curve_data.py#L88-L113)
object which is a container of the XY data is also replaced with the
data frame in a follow up PR. Since this table should contain predefined
columns such as `xval`, `yval`, `yerr`, I was assuming this container
could be a subclass of `ThreadSafeDataFrame` -- but this was not a right
assumption.

Since the curve analysis always runs on a single thread (analysis
callbacks might be run on multiple threads and thus
`AnalysisResultTable` must be thread-safe), this curve data frame
doesn't need to be thread-safe object. In this PR, a functionality to
define default columns of the table is reimplemented as a Python mixin
class so that the function to add default columns will be used also for
curve data frame without introducing the unnecessary thread safe
mechanisms. `AnalysisResultTable` is a thread safe container but the
functionality to manage default columns is delegated to the mixin.

84 of 84 new or added lines in 4 files covered. (100.0%)

12384 of 14028 relevant lines covered (88.28%)

3.53 hits per line

Relevant lines Covered
14028 RELEVANT LINES 12384 COVERED LINES
3.53 HITS PER LINE
Source Files on gh-readonly-queue/main/pr-1252-1acc02d49d7c8baaae3f495af049b58f24a8d0c3

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
6009595088 gh-readonly-queue/main/pr-1252-1acc02d49d7c8baaae3f495af049b58f24a8d0c3 Reimplement AnalysisResultTable (#1252) ### Summary Follow-up of #1133 for data frame. ### Details and comments I realized I had some mistake when I wrote a base class of `ThreadSafeDataFrame`. We plan to move the curve data (XY data) to the ... push web-flow github
88.28
See All Builds (105)