ProboCI / probo-asset-receiver

86%

master: 75%

LAST BUILD ON BRANCH fix/lol/delete-asset-versions

branch: fix/lol/delete-asset-versions

CHANGE BRANCH

x

Reset

• fix/lol/delete-asset-versions
• 1.0.1
• 2020-03-06-Sprint-6
• asset-byte-size
• asset-size
• assetSize
• auth
• dependabot/npm_and_yarn/eslint-6.6.0
• feature/addition-rest-endpoints
• feature/asset-size-migration
• feature/capture-asset-size
• feature/file-storage-s3-plugin
• feature/lol/config-settings-comments
• feature/lol/database-backups
• feature/lol/pause-uploads
• file-storage-s3-plugin
• fix-current-asset
• fix/lol/asset-upload-connection
• master
• v2.0.0
• v2.0.1
• v2.0.2
• v2.0.3
• v2.1.0
• v2.2.0
• v2.3.0
• v2.3.1

Build # 163

Build Type

push

travis-ci

Committed by lliss

Commit Message

Delete asset versions when deleting asset.

We had been leaving historical asset versions on disk and in the LevelDB
database after deleting an asset. This was not the desired functionality
as it would eventually result in us having to run migrations to remove
old asset versions. Currently we do not give users a way to manage these
so it can be assumed that a user will expect all data related to an
asset to be removed upon deletion and this includes historical versions.

While testing, I found an issue in which the AWS uploader could fail and
incorrectly report to the uploader that it had succeeded. To deal with
this condition I added an error handler on the stream and ensured the
the AWS upload function emits an error event when relevant.

Run Details

40 of 40 new or added lines in 3 files covered. (100.0%)

344 of 400 relevant lines covered (86.0%)

5.26 hits per line