ProboCI / probo-asset-receiver

84%

master: 75%

LAST BUILD ON BRANCH fix/lol/asset-upload-connection

branch: fix/lol/asset-upload-connection

CHANGE BRANCH

x

Reset

• fix/lol/asset-upload-connection
• 1.0.1
• 2020-03-06-Sprint-6
• asset-byte-size
• asset-size
• assetSize
• auth
• dependabot/npm_and_yarn/eslint-6.6.0
• feature/addition-rest-endpoints
• feature/asset-size-migration
• feature/capture-asset-size
• feature/file-storage-s3-plugin
• feature/lol/config-settings-comments
• feature/lol/database-backups
• feature/lol/pause-uploads
• file-storage-s3-plugin
• fix-current-asset
• fix/lol/delete-asset-versions
• master
• v2.0.0
• v2.0.1
• v2.0.2
• v2.0.3
• v2.1.0
• v2.2.0
• v2.3.0
• v2.3.1

Build # 156

Build Type

push

travis-ci

Committed by lliss

Commit Message

Fix AWS asset receiver upload connection end.

The asset upload endpoint would not properly fire an end event when
working with the AWS S3 plugin. The cause of this was that we were
piping the file data through to the S3 uploader but our return string
had no way to detect that the S3 API's done callback had finished. Here
we fix the issue by closing the stream when S3 reports that the file has
successfully uploaded.

Run Details

1 of 1 new or added line in 1 file covered. (100.0%)

316 of 375 relevant lines covered (84.27%)

5.35 hits per line