PragTob / benchee

94%

master: 94%

LAST BUILD ON BRANCH trying-to-figure-out-nil-problem-in-benchee-csv

branch: trying-to-figure-out-nil-problem-in-benchee-csv

CHANGE BRANCH

x

Reset

• trying-to-figure-out-nil-problem-in-benchee-csv
• 0-runtime-handling
• 0.10.0
• 0.11.0
• 0.12
• 0.12.0
• 0.12.1
• 0.12.1-release
• 0.13
• 0.13-updates
• 0.13.0
• 0.13.1
• 0.13.2
• 0.13.2-cherry-pick
• 0.14.0
• 0.7.0
• 0.8.0
• 0.9.0
• 1.5.0-rc2-update
• 1.6-rc0
• Bessels-Correction
• Issue-123
• Issue-188
• Issue-208
• Issue-259
• Issue-51
• Issue-53
• Issue-68
• PragTob-patch-1
• account-for-old-generation-memory-measurement
• add-benchee_markdown-formatter
• add-percentile
• add-percentiles
• after-scenario-inputs
• application-inflection
• appveyor
• before-after-each-simple
• before-each-inputs
• before_after_scenarios
• before_scenario_altering_input
• behaviour-reuse
• calculate-memory-stats
• changelog-update
• changelog-updates
• check-in-tool-versions
• config-types
• conversion-units
• coveralls-try
• credo
• deprecations
• deps-up
• deps-updates
• dialyzer-weirdness
• doc-it
• drop-1.2-support-cleanups
• drop-negative-memory-measurements
• dry-run
• easy-updates
• eliminate-duplicated-benchmarking-messages
• elixir-1-5-2
• elixir-1.5
• elixir-1.5.1
• elixir-1.6-final
• elixir-1.6.3
• elixir-1.7.0-rc1
• elixir-1.8
• elixir-erlang-updates
• elixir-update
• erlang-module-style
• estimated-run-times-fix
• exact-elixir-version
• exguard
• fix-race-condition-with-tracer
• flaky-overhead-test
• format-bigger-floats
• format-samples
• format-test
• formatter-definition
• formatter-options-closer
• formatting
• formatting-1
• formatting-2
• formatting-3
• formatting-everything
• formatting-everything-2
• formatting-everything-3
• formatting-everything-4
• formatting-everything-5
• formatting-everything-6
• formatting-everything-7
• function-call-overhead
• gfvcastro-update-to_filename-pattern
• gigabyte-binary-interpretation
• hmm-updates
• hooks-documentation
• hooks-documentation-alt
• inchex-update
• issue-191
• jose-erlang-compatibility
• joshnuss-atom-input-keys
• length-sample
• lwalter-master
• macro-tests
• master
• measure-memory-3
• memory-again
• memory-breaker-integreation-test
• memory-documentation
• memory-format-crash
• memory-formatting-bug
• memory-measurement-issues
• memsup-get-stystem-memory
• mention-slack
• moaree-updates
• nano-seconds
• new-elixir-and-erlang
• no-prying
• parallel-bug
• parallel-bug-alternative
• pass-values-to-after
• pipeify
• random-improvements
• readme-adjustments
• relative-statistics
• remove-not-always-working-cpu-speed-test
• safe-coveralls
• scale-printed-configuration-times
• scenario-data-processed
• scenario-first-class
• separate-memory-and-runtime-measurement
• simplify-measure-memory
• sort-scenarios
• statistics-mode
• statistics-timeout
• store-and-load-documentation
• store-previous-runs
• tagged-save-numbers
• test-general-mhz-case
• travis-do-you-master
• travis-vm-fix-dialyzer
• type-checking
• unit-scaling-top-level-option
• update-deep-merge
• update-travis
• update-versions
• updates
• updatessss
• upgrades
• warn-memory-otp-18
• warnings-as-errors
• zachdaniel-fix-tag-name

Build # 1195

Build Type

Pull #252

travis-ci

Committed by web-flow

Commit Message

Fix issue of passing nil to formatters (from CSV PR)

Interestingly the bug occurred thanks to our legacy format support.
Can't wait to get rid off it ;)

I changed the code for the formatter test to really make sure that
the same options passed to format/2 are also passed to write/2.
It didn't find the bug as the bug was in Configuration, but I
think it's still an improvement worth keeping.

Once this code is merged, we can delet the one unnecessary line
from the CSV formatter. Already tried it and it worked :tada:

Pull Request Pull Request #252: Fix issue of passing nil to formatters (from CSV PR)

Run Details

7 of 7 new or added lines in 1 file covered. (100.0%)

580 of 614 relevant lines covered (94.46%)

15976.82 hits per line