• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

PennockTech / tabular
78%
main: 77%

Build:
Build:
LAST BUILD BRANCH: pdp/zizmor
DEFAULT BRANCH: main
Repo Added 16 Mar 2018 02:59AM UTC
Files 31
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH alignment
branch: alignment
CHANGE BRANCH
x
Reset
  • alignment
  • main
  • master
  • next
  • pdp/zizmor
  • pdp/zizmor-and-bump-ci-versions
  • travis
  • v1.1.0
  • v1.1.1
  • v1.1.2

pending completion
39

push

travis-ci

philpennock
Bug-fix property removal

The chaining logic was checking for "no child? oh, return" _before_
checking the current key, so would never remove an item which was the
last in the chain.

Renaming the child entry to be `child` not `propertySet` (anonymous
embed to named) made it much clearer.  Changing the child printing in
`GoString()` from `#v` to `#+v` also helped.

Fixed the removal logic.  Use the JSON skipability tests to exercise
this logic.

Since we return `nil` for "not found", I decided that there's no point
to being able to store a nil value, so have changed the API definition
such that trying to store nil _means_ removal.  (I did have a
`RemoveProperty` sentinel in here, but nil is actually clearer, since we
want `GetProperty()` to return just a value, no error signalling.)

25 of 25 new or added lines in 1 file covered. (100.0%)

1241 of 1589 relevant lines covered (78.1%)

162.29 hits per line

Relevant lines Covered
Build:
Build:
1589 RELEVANT LINES 1241 COVERED LINES
162.29 HITS PER LINE
Source Files on alignment
  • List 0
  • Changed 7
  • Source Changed 1
  • Coverage Changed 7
Coverage ∆ File Lines Relevant Covered Missed Hits/Line

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
39 alignment Bug-fix property removal The chaining logic was checking for "no child? oh, return" _before_ checking the current key, so would never remove an item which was the last in the chain. Renaming the child entry to be `child` not `propertySet` (anony... push 06 May 2018 02:50AM UTC philpennock travis-ci pending completion  
37 alignment coverage: Go 1.10 invocation, add more tests Added more tests to improve coverage a little. Found location.go was still reporting as 0%, looked and saw that Go 1.10 introduced coverage testing across multiple packages at once, so simplified scri... push 05 May 2018 09:03AM UTC philpennock travis-ci pending completion  
36 alignment Merge branch 'master' into alignment push 04 May 2018 11:55PM UTC philpennock travis-ci pending completion  
34 alignment copyright year bumps push 04 May 2018 11:32PM UTC philpennock travis-ci pending completion  
33 alignment Implement skipable columns for JSON * Actually implement the Column-0-is-defaults-for-properties concept * Move alignment package `align` → `properties/align` + still only existed on non-master branch, never part of API, safe to move * Test... push 04 May 2018 11:14PM UTC philpennock travis-ci pending completion  
32 alignment Merge branch 'master' into alignment push 04 May 2018 06:58PM UTC philpennock travis-ci pending completion  
30 alignment Center alignment; markdown support push 23 Mar 2018 12:28AM UTC philpennock travis-ci pending completion  
See All Builds (45)
  • Repo on GitHub
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc