PRX / PRX.org-Frontend

85%

master: 87%

LAST BUILD ON BRANCH deploy/cache_assets

branch: deploy/cache_assets

CHANGE BRANCH

x

Reset

• deploy/cache_assets
• about_us
• ad_unit
• ad_unit_two
• chore/backend_domain_change
• chore/cache_assets
• chore/cleanup_build
• chore/refactor_styles
• chore/travis_and_deploy
• chore/update_build
• design/footer
• feat/ad_display
• feat/analyze_audio
• feat/disable_experiments_runner
• feat/display_tweaks
• feat/docs
• feat/drag_and_drop
• feat/drawer
• feat/evap_upload_svc
• feat/evaporatejs
• feat/funding_page
• feat/large_player
• feat/nonblock_css
• feat/og_canon
• feat/pitch-pages
• feat/prerender_all
• feat/press_page
• feat/producer
• feat/progress_and_playback
• feat/radiotopia_donations
• feat/scroll_popup
• feat/series_public
• feat/signal_from_mobile_site
• feat/sticky_header
• feat/swipe
• feat/tcf_dnd_upload
• feat/team_page
• feat/terms_pages
• feat/upload_demo
• feat/validate_audio
• feat/welcome_mat
• fix/coveralls
• fix/footer_spacing
• fix/series_links
• fix/series_view_all
• fix/titles
• master
• new_mobile_home
• origin/design/footer
• producer_metadata
• see_all_stories_fix
• series_info
• short_names_for_curators
• stage/static_page
• story_share
• style/modal

Build # 747

Build Type

push

travis-ci

Committed by chrisrhoden

Commit Message

Cache assets between deploys

This speeds up deploys considerably by caching the minified assets.

There is a concern, though, that changes may not be picked up because it just
uses timestamps. As a result, we manually set the timestamps of files generated
by the build process into the cache to be the timestamp of the commit being
deployed.

This could cause problems if file timestamps are dramatically behind the commit
timestamps (the specific case involves a deploy happening between a file
being created and that file being committed for the first time) but this can
be addressed in the future by first touching the source assets with the commit's
timestamp which, while I am not yet doing, should protect us completely.

I'd also like to consider using a copy instead of the symlink used here because
there are definitely race conditions at play if multiple deploys are happening
simultaneously.

Run Details

1707 of 2000 relevant lines covered (85.35%)

47.62 hits per line