PHP-DI / PHP-DI

85%

master: 95%

LAST BUILD ON BRANCH lock-containerbuilder

branch: lock-containerbuilder

CHANGE BRANCH

x

Reset

• lock-containerbuilder
• 179
• 257
• 257-parent-private-properties
• 300
• 345
• 4.4.10
• 4.4.8
• 4.4.9
• 4.x
• 5.0.0
• 5.0.2
• 5.0.3
• 5.0.4
• 5.1
• 5.1.0
• 5.1.0-beta1
• 5.2.0
• 5.2.0-beta1
• 5.2.1
• 5.2.2
• 5.3
• 5.3.0
• 5.3.0-beta1
• 5.4
• 5.4.0
• 5.4.0-beta1
• 5.4.1
• 5.4.2
• 5.4.3
• 5.4.4
• 5.4.5
• 5.4.6
• 547-poc-compile-all-classes
• 567-silence-some-errors-at-compilation
• 6.0
• 6.0-release
• 6.0.0
• 6.0.0-alpha1
• 6.0.0-alpha2
• 6.0.0-alpha3
• 6.0.0-alpha4
• 6.0.0-beta1
• 6.0.0-beta2
• 6.0.0-beta3
• 6.0.1
• 6.0.10
• 6.0.11
• 6.0.2
• 6.0.3
• 6.0.4
• 6.0.5
• 6.0.6
• 6.0.7
• 6.0.8
• 6.0.9
• 6.1.0
• 6.2.0
• 6.2.1
• 6.2.2
• 6.2.3
• 6.2.4
• algolia-search
• analysis-Xaj6v7
• analysis-qvZ6mN
• analysis-zYEjAz
• apcu-cache
• array-cache
• better-error-message
• bugfix
• cache-refactoring
• cache-wildcard-definitions
• closure-serialization
• compile-decorators
• compile-factories
• compile-recursively
• compiler
• definition-interop
• documentation-lazy-injection
• exception_messages
• feature/Compiler
• fix-242
• fix-366
• fix-520
• fix-526
• fix-648
• gitter
• handle-nested-definitions
• hhvm-build
• improve-645
• improve-documentation-index
• issue-628
• master
• mnapoli-patch-1
• module-kernel
• nested-autowire
• new-container-without-parameters
• optimizations
• performance-improvements
• php55
• php7
• php7-strict-types
• php8
• pr-536
• proxymanager-2
• psr-11
• psr-16
• refactor-object-to-create
• reintegrate-533
• release-5.0.4
• release-5.3
• remove-dumpers
• remove-invoker-interface
• remove-scopes
• rename-compile
• rename-exception
• revert-364-patch-3
• revert-6.0.7
• self-resolving-definitions
• service-provider
• simpler-definition-helper
• slim4
• standardize-nested-definitions
• style
• styleci
• v6.remove-link
• v6_di_get_autowire_interface
• wildcard-autowire

Build # 1362

Build Type

push

travis-ci

Committed by mnapoli

Commit Message

#421 Lock the ContainerBuilder once the container has been built

The goal is to detect errors sooner when users will do something like this:

```php
$containerBuilder->addDefinitions(...);

$container = $containerBuilder->build();

$containerBuilder->addDefinitions([
    'foo' => 'bar',
]);

$container->get('foo'); // Exception
```

Definitions (or anything actually) added after the container was created is ignored, but it sometimes can be not obvious.

By "locking" the builder after the container is created (throwing an exception on all modifications) could help.

Run Details

11 of 11 new or added lines in 1 file covered. (100.0%)

1010 of 1193 relevant lines covered (84.66%)

3.97 hits per line