OverloadUT / home-assistant

94%

dev: 93%

LAST BUILD ON BRANCH fix-isy994-device-detection

branch: fix-isy994-device-detection

CHANGE BRANCH

x

Reset

• fix-isy994-device-detection
• add-deebot-vacuum
• add-ecovacs-component
• deebot-subscribe-mocks
• dev
• ecovacs-fixes
• fix-12415-isy-sensors-not-binary
• fix-13384-isy-moisure-sensors
• fix-fix-isy994-fan-detection
• fix-isy-blocker
• fix-isy-log-spam
• fix-isy994-negative-node-usage-detection
• fix-isy994-newest-firmware
• fix-moisure-sensors-unknown-state
• fix-universal-home-theater-unavailable-state
• history-performance-improvements
• history-performance-improvements-round2
• isy994-control-events
• isy994_sensor_improvements
• master
• rachio-improvements
• threshold-sensor-delay-feature
• update-license

Build # 75

Build Type

push

travis-ci

Committed by OverloadUT

Commit Message

Fixed 3 small issues in isy994 component

1. FanLincs have two nodes: one light and one fan motor. In order for each node to get detected as different Hass entity types, I removed the device-type check for FanLinc. The logic will now fall back on the uom checks which should work just fine. (An alternative approach here would be to special case FanLincs and handle them directly - but seeing as the newer 5.x ISY firmware already handles this much better using NodeDefs, I think this quick and dirty approach is fine for the older firmware.) Fixes #12030
2. Some non-dimming switches were appearing as `light`s in Hass due to an duplicate NodeDef being in the light domain filter. Removed! Fixes #12340
3. The `unqiue_id` property was throwing an error for certain entity types that don't have an `_id` property from the ISY. This issue has always been present, but was exposed by the entity registry which seems to be the first thing to actually try reading the `unique_id` property from the isy994 component.

Run Details

31293 of 33270 relevant lines covered (94.06%)

2.82 hits per line