OpenWebslides / openwebslides-frontend

83%

master: 100%

LAST BUILD ON BRANCH refactor-topics-save-saga

branch: refactor-topics-save-saga

CHANGE BRANCH

x

Reset

• refactor-topics-save-saga
• add-error-hierarchy
• alerts
• alerts-mark-as-read
• api-error-handling
• api-response-flow-type
• api-subresource
• api-v8
• api-versioning
• auth-persist
• auth-redirect
• bug-fix-authorized-fetch
• cleanup-and-refactor-authentication-module-and-page-component
• cleanup-api-lib
• cleanup-api-requests-status-module
• cleanup-app-and-core-components
• cleanup-content-items-module
• cleanup-errors
• cleanup-feed
• cleanup-history
• cleanup-localstorage
• cleanup-pages
• cleanup-sidebars
• cleanup-topics
• cleanup-users
• clickable-users-feedItems
• cocos-feedback
• commit-message
• commits
• commits-api
• content-item-selection
• content-items-collapse
• content-items-toolbar
• contribute-sidebar
• create-pr
• demo
• deployment
• dirty-bit
• disable-prefer-destructuring-eslint-rule
• edit-topic-title-and-description
• enhance-apidimmer
• eslint-import-no-internal-modules
• eslint-index-file-sorting
• eslint-jest
• eslint-promise
• favicon
• feature-api
• feature-auth-pages
• feature-authentication
• feature-authentication-pages
• feature-authentication-sagas
• feature-basic-editor-controls
• feature-basic-slide-rendering
• feature-confirm
• feature-content-item-sagas
• feature-content-item-sagas2
• feature-converting-paragraphs-to-headings
• feature-course-rendering
• feature-deployment
• feature-dummy-data
• feature-dummy-providers
• feature-e2e-testing
• feature-editable-content-items
• feature-editable-content-items-temp
• feature-editor-page
• feature-email-confirmation-needs-fixing
• feature-error-sagas
• feature-feed-api
• feature-flash
• feature-history
• feature-navbar-design
• feature-semantic-ui-less
• feature-slide-splitting
• feature-stying-slides-min
• feature-styling-slides
• feature-styling-slides-copied
• feature-styling-slides-custom-theme
• feature-styling-slides-min
• feature-topic-sagas
• feature-travis
• feature-user-sagas
• feed-refactor
• final-presentation
• fix-action-type-naming
• fix-api-config
• fix-api-url-manual-setup
• fix-babel-webpack-config
• fix-broken-users-update-saga-test
• fix-circular-dependencies
• fix-circular-dependency-plugin
• fix-config-file
• fix-confirmation-api
• fix-contentitems-minor-structural-issues
• fix-delete-last-content-item-bug
• fix-editor-url-ids
• fix-error-reducer
• fix-eslintrc-disable-certain-rules-for-tests
• fix-flow-config-false-negatives
• fix-jest-coverage-report
• fix-missing-eslint-check-for-class-properties
• fix-module-dependency-issues
• fix-multiple-smaller-bugs
• fix-owsdev-url
• fix-readme-command
• fix-reducer-flow-error
• fix-remove-account
• fix-saga-communication-and-error-handling
• fix-travis
• fix-travis-build-speed
• fix-unexpected-json
• fix-webpack-build
• floating-toolbar
• flow-lint
• fork-topic
• formik
• gravatar-refactor
• home-refactor
• home-ui-modules
• hotfix
• invert-modal-colours
• issue-115-render-root-content-item
• issue-apierror-docs
• issue-closing-wednesday
• issue-fetch-email
• issue-i18n
• issue-refactor-feed
• issue-token-type
• library-ui
• link-auth-with-library
• link-auth-with-profile-page
• markdown-toolbar
• master
• misc-styling
• modal-own-implementation
• modal-with-component-state
• modals
• module-sagas
• module-testing
• navbar-generalization
• navbar-generalization-2
• newtopic
• newtopic-rebased
• privacy-policy
• profile
• project-maintenance-between-sprint-10-and-11
• project-maintenance-sprint-12
• project-maintenance-sprint-13
• project-maintenance-sprint-15
• project-maintenance-sprint-15-2
• project-maintenance-sprint-16
• project-maintenance-sprint-18
• project-maintenance-sprint-8
• pull-request-api-calls
• pull-requests
• redux-persistence
• refactor-action-creators
• refactor-api-configuration
• refactor-asyncfetch-errors
• refactor-component-tests-dummy-props
• refactor-content-item-types
• refactor-module-imports
• refactor-selectors-using-reselect
• refactor-topic-actions-and-sagas
• refresh-token
• remove-type-suffix-rename-feed-module
• rename-event-type
• rename-feed-module
• rename-notifications-to-feed
• revert-delete-dummy-topics
• rewrite-page
• robots-txt
• semantic-ui-modal
• set-topic-access
• share-topic
• show-pull-request
• shut-up-travis
• sidebar
• single-sign-on
• small-fixes
• socialfeed-refactor-no-verify
• sprint-14-maintenance
• statistics
• styling
• testing
• testing-index-app-and-content-items-sagas
• text-content-items
• topic-dirty-bit
• topic-root-content-item-id
• topics
• ui-improvements
• ui-refactored
• update-dependencies-and-eslintrc
• update-flow-to-latest-version
• update-flow-to-v0.70
• update-flow-to-v0.72
• update-react-to-v16.3
• update-to-api-v4
• user-module
• user-settings
• v1.0.0
• v1.1.0
• v2.0.0
• v2.1
• various-design
• various-minor-fixes
• various-small-changes
• versioning
• view-course
• viewer-updates

Build # 795

Build Type

push

travis-ci

Committed by Dromin

Commit Message

Changes to the way descendant items are fetched in topics saveSaga:
- Removed content-items/lib/get-all-descendants, since its functionality is covered by content-items/lib/find/getAllDescendantItems
- Renamed getAllDescendantsById selector into getSelfAndAllDescendantsById to better describe its functionality; refactored it to use the find lib
- Made getSelfAndAllDescendantsById a cached selector using re-reselect, since it takes the id as an argument
- Refactored topics saveSaga to use getSelfAndAllDescendantsById selector

Run Details

547 of 659 branches covered (83.0%)

Branch coverage included in aggregate %.

1687 of 2043 relevant lines covered (82.57%)

18.39 hits per line