NotJordanZA / SDP-Project

56%

main: 55%

LAST BUILD ON BRANCH schedules-fix

branch: schedules-fix

CHANGE BRANCH

x

Reset

• schedules-fix
• Admin
• AdminAllBookings-testing
• AdminCreateBooking-testing
• AdminCreateBooking-testing-new
• AdminRecurringBookings-testing
• AdminRecurringBookings-testing-new
• AdminScreens
• ManageRequesttesting
• Notifications2
• Notificationsreddot
• Reverting-homepage
• admin-create-booking
• admin-requests-management-ui
• admin-user-parity
• allowing-marker-emails
• api-key-environment-variables
• api-key-integration
• api-key-merge
• bookings-api-checks
• codeCleanup
• coveralls-badge
• coverallsSetup
• deployment
• deployment-port-fixes
• development
• development-backup
• dining-api
• edit-booking-notifications
• events-delete-api
• express-file-structuring
• feedback-changes
• firebase-functions-hosting
• homepage-notifications-fix
• homepage-ui
• homepage-ui-big-buttons
• homepageFix
• login-authentication
• main
• manage-bookings-testing
• manage-reports-ui
• manage-requests-ui
• manage-venues-styling
• manageReportsTesting
• missing-tests-venues
• missing-venues-tests
• mobile-header-ui
• navBarFix
• newAdmin
• newbranchAdmin
• notification-sorting
• notification-util
• notifications
• notifications-hotfix
• notifications-scroll-hotfix
• popupForm-testing
• readME
• readMe-user-manual
• readme-accounts
• rekognitionTemp
• repFix
• reports-api-keys
• reportsFix
• safetyIntegration
• schedules-migration
• sidebar-ui
• sidebar-z-index-hotfix
• slight-UI/UX-adjustments
• spare
• suggestions
• tamir
• testingadminRequests
• tutoring
• user-edit-bookings-merge
• venue-options
• venues-css-fixes
• venues-page-notifications
• venues-schedules-fix
• venues/findByField-api

Build # 2431c805-5824-45de-b161-a1022dc0b6de

Build Type

Pull #118

circleci

Committed by NotJordanZA

Commit Message

fixed unnecessary API calls

-each venue was calling the get Schedules API, changed it to have one call with all schedules passed into each venue and sorted after

Pull Request Pull Request #118: fixed unnecessary API calls

Run Details

387 of 711 branches covered (54.43%)

Branch coverage included in aggregate %.

3 of 5 new or added lines in 3 files covered. (60.0%)

3 existing lines in 1 file now uncovered.

666 of 1169 relevant lines covered (56.97%)

47.99 hits per line