NextThought / nti.externalization

100%

master: 100%

LAST BUILD ON BRANCH issue67-clean

branch: issue67-clean

CHANGE BRANCH

x

Reset

• issue67-clean
• 1.0.0
• 1.0.0a1
• 1.0.0a10
• 1.0.0a11
• 1.0.0a12
• 1.0.0a13
• 1.0.0a14
• 1.0.0a8
• 1.0.0a9
• 1.1.0
• 1.1.1
• 1.1.2
• 1.1.3
• 2.0.0
• 2.1.0
• 2.3.0
• auto-anon-dict-fields
• benchmarks
• better-anon-fallback
• dep-updates
• deprecated-imports
• drop-object-hook
• eid-persistent-allowed
• externalize-fraction
• factory
• faster_removeAllProxies
• feature/EID-allow-non-str
• feature/call-adapters
• fix-sphinx-doctests
• gha
• import-sorts
• issue102
• issue104
• issue105
• issue109
• issue111
• issue117
• issue16
• issue21
• issue23
• issue27
• issue28
• issue30
• issue33
• issue35
• issue43
• issue48
• issue51
• issue52
• issue52-refactor
• issue52-refactor-ext
• issue59
• issue60
• issue63
• issue64
• issue73
• issue73-2
• issue90
• issue92
• issue94
• issue97
• lint
• locateddict-fixes
• master
• nopickle-persistent
• persistent44
• prefs
• premature-optimization
• require-updater-anon
• set-primitive_out_ivar
• state-is-maintained-recursion-error
• tighter-anon-dict
• unicode-field-names
• will-update-events
• zcml-factory
• zope-interface5

Build # 173

Build Type

Pull #69

travis-ci

Committed by web-flow

Commit Message

Monkey-patch FieldProperty so we can avoid double-validation.

Fixes #67

Add tests that this doesn't break anything.

In our simple tests, this makes us at least 10% faster.

2.7:

| Benchmark                    | 27_list_fieldproperty3 | 27_list_fieldproperty_patched3 |
|------------------------------|------------------------|--------------------------------|
| __main__: fromExternalObject | 1.43 ms                | 1.27 ms: 1.12x faster (-11%)   |

Not significant (1): __main__: toExternalObject

3.6 (taken during a backup, results for toExternalObject had a *huge*
stddev of 40%):

| Benchmark                    | 36_list_fieldproperty | 36_list_fieldproperty_patched2 |
|------------------------------|-----------------------|--------------------------------|
| __main__: toExternalObject   | 428 us                | 577 us: 1.35x slower (+35%)    |
| __main__: fromExternalObject | 1.43 ms               | 1.19 ms: 1.20x faster (-17%)   |

Pull Request Pull Request #69: Monkey-patch FieldProperty so we can avoid double-validation.

Run Details

18 of 18 new or added lines in 1 file covered. (100.0%)

4189 of 4192 relevant lines covered (99.93%)

6.5 hits per line