Netflix / security_monkey

51%

develop: 68%

LAST BUILD ON BRANCH policydiff_fix

branch: policydiff_fix

CHANGE BRANCH

x

Reset

• policydiff_fix
• 1.1.1
• 1.1.2
• 1.1.3
• Bridgewater-7923_OverrideScores
• Bridgewater-7961_BulkToggleAccounts
• Bridgewater-9033_TestInDir
• Bridgewater-9331_AddWatcherConfigs
• add-glacier-support
• add-travis-pylint
• add_cloudtrail_gettrailstatus_permission_to_docs
• add_ephemeral_to_vpn
• add_kms_vpn_permissions
• add_lambda_auditor
• alb_auditor
• auditor_cloudaux_fixes
• batch_watcher_email_diffs
• can_upgrade_sqlalchemy_maybe
• changelog_updates_090
• cloudaux_ephemeral_fixes
• cloudaux_gcp_extra
• cloudaux_watcher
• coverage
• dart_fix_warnings
• db_indexes
• deleteImprovement
• develop
• distinct_performance_optimizations
• duplicate_arn_fix
• ebssnapshotauditor
• ec2_image_watcher
• elb_sg_checks_use_object_store
• enhance
• escape
• fix_amazon_accounts
• fix_s3_recorded_incorrect_region
• followup_pr_825
• glacier_auditor
• gunicorn_optional
• iam_auditors_refactor
• iamuser_auditor_fixes
• increase_timeout
• issue_251_fix_iamssl_issuer_exception_regression
• issue_373_kms_auditor_conditions
• issue_421_rds_db_instance_ephemeral
• issue_466_s3_auditor_arn_class
• issue_477_iamuser_auditor_bug
• issue_488_add_rds_ephemeral
• issue_494_flask_wtf_v14
• issue_501_security_trackable
• issue_507
• issue_537_accounts_filtering
• issue_604_elb_auditor_rfc1918
• issue_620_attempt_2
• issue_620_insecureplatform
• issue_645_export_s3name_broken
• issue_670_unicode_problems_policydiff
• issue_672_aws_accounts_path
• issue_674_install_missing_files
• issue_705_alert_batch_watchers
• issue_712_favicon
• issue_729_ephemerals_broken_cloudaux
• issue_783_sanitize_account_identifier
• issue_844_remove_justified_fixed_issues_from_email
• issue_873
• issue_889
• issue_890_icmp_listener
• issue_preservation
• item_issue_score_hybrids
• kms_auditor_fixes_principal_service
• lambda_function
• log_reporter_runtime
• log_ssl_alt_name
• make_cloudaux_version_ephemeral
• master
• monkey_do
• monkeysecurity-quickstart-patch
• move_dashboard
• noop_migration_b8ccf5b8089b
• nullauditor
• objectstore_improvements
• perf
• pin_idna
• prepare_v091
• py3fix
• quickstart_updates
• rds_auditor
• rds_snapshot_auditor
• refactor_securitygroup_auditor
• remove_deprecated_fields
• remove_securitymonkeysettings_from_travis
• robertoriv-feature/check_assume_role_from_unknown
• s3-logging-auditor
• saml_provider_watcher
• saml_watcher
• sentry_integration
• sgauditor_ipv6
• sso_updates
• supertom-acct_type
• supervisor_venv_problem
• test_policydiff
• travis_docker
• trust_policy_is_resource_policy
• unused_access_key_report
• update_ARN_condition_extraction_stringequalsignorecase
• update_docker_docs_issue_603
• update_s3_auditor
• update_some_dependencies
• upgrade_jinja2
• use_github_moto
• v0.8.0
• v0.9.0
• v0.9.1
• v0.9.2
• v1.0.0
• v1.1.0
• windows_dev_instructions

Build # 523

Build Type

push

travis-ci

Committed by monkeysecurity

Commit Message

Fixing two policy diff cases.

1) If provided with a string, json.loads() is used, which often means
strings in the extracted structure are of type unicode.  If the same
structure is also provided as a dict, there will often be problems where
a str and a unicode are seen as different objects.  To fix, we simply dump
any datastructures and read them back in with the json lib.

2) The lib was not properly handling null values and was ignoring them entirely
in the output.

Run Details

5 of 5 new or added lines in 1 file covered. (100.0%)

4539 of 8883 relevant lines covered (51.1%)

0.51 hits per line