Netflix / genie

93%

master: 94%

LAST BUILD ON BRANCH v4.0.0-rc.74

branch: v4.0.0-rc.74

CHANGE BRANCH

x

Reset

• v4.0.0-rc.74
• 3.0.x
• 3.1.x
• 3.2.x
• 3.3.x
• 4.0.x
• 4.1.x
• 4.2.x
• SlowBuildDebug
• c.n.genie.web.events.GenieEventBusImpl
• dependabot/npm_and_yarn/genie-ui/npm-6.13.4
• dev-snapshot
• develop
• master
• replace-bintray
• revert-923-GENIE-412-job-working-directory
• rollbackGradleChanges
• rpalcolea-patch-1
• snapshot-test
• v3.3.11
• v3.3.12
• v3.3.13
• v3.3.15
• v3.3.16
• v3.3.18
• v3.3.19
• v3.3.20
• v3.3.22
• v4.0.0
• v4.0.0-rc.1
• v4.0.0-rc.10
• v4.0.0-rc.11
• v4.0.0-rc.12
• v4.0.0-rc.13
• v4.0.0-rc.14
• v4.0.0-rc.15
• v4.0.0-rc.16
• v4.0.0-rc.19
• v4.0.0-rc.2
• v4.0.0-rc.20
• v4.0.0-rc.21
• v4.0.0-rc.22
• v4.0.0-rc.23
• v4.0.0-rc.24
• v4.0.0-rc.25
• v4.0.0-rc.27
• v4.0.0-rc.28
• v4.0.0-rc.29
• v4.0.0-rc.31
• v4.0.0-rc.32
• v4.0.0-rc.33
• v4.0.0-rc.34
• v4.0.0-rc.35
• v4.0.0-rc.36
• v4.0.0-rc.37
• v4.0.0-rc.38
• v4.0.0-rc.4
• v4.0.0-rc.41
• v4.0.0-rc.42
• v4.0.0-rc.43
• v4.0.0-rc.44
• v4.0.0-rc.45
• v4.0.0-rc.46
• v4.0.0-rc.47
• v4.0.0-rc.48
• v4.0.0-rc.49
• v4.0.0-rc.5
• v4.0.0-rc.50
• v4.0.0-rc.51
• v4.0.0-rc.52
• v4.0.0-rc.53
• v4.0.0-rc.54
• v4.0.0-rc.55
• v4.0.0-rc.56
• v4.0.0-rc.57
• v4.0.0-rc.58
• v4.0.0-rc.59
• v4.0.0-rc.60
• v4.0.0-rc.61
• v4.0.0-rc.63
• v4.0.0-rc.64
• v4.0.0-rc.65
• v4.0.0-rc.66
• v4.0.0-rc.67
• v4.0.0-rc.68
• v4.0.0-rc.69
• v4.0.0-rc.70
• v4.0.0-rc.71
• v4.0.0-rc.72
• v4.0.0-rc.73
• v4.0.0-rc.75
• v4.0.0-rc.77
• v4.0.0-rc.78
• v4.0.0-rc.80
• v4.0.0-rc.81
• v4.0.0-rc.82
• v4.0.0-rc.83
• v4.0.0-rc.84
• v4.0.0-rc.85
• v4.0.0-rc.86
• v4.0.0-rc.87
• v4.0.0-rc.88
• v4.0.0-rc.89
• v4.0.0-rc.9
• v4.0.0-rc.90
• v4.0.0-rc.91
• v4.0.0-rc.92
• v4.0.0-rc.94
• v4.0.0-rc.95
• v4.0.0-rc.96
• v4.0.0-rc.97
• v4.0.0-rc.98
• v4.0.1
• v4.0.2
• v4.0.3
• v4.0.4
• v4.0.5
• v4.0.6
• v4.1.0
• v4.1.1
• v4.1.2
• v4.1.3
• v4.1.4
• v4.1.5
• v4.1.6
• v4.2.0
• v4.2.1
• v4.2.2
• v4.3.0

Build # 2890

Build Type

push

travis-ci

Committed by mprimi

Commit Message

Bug: integer overflow for large files

Updates the gRPC protocol to allow downloading files that are over 2GB in size.
The previous version of the protocol was (naively) using int32 for offsets. So anything beyond the 2GB mark would produce an integer overflow server-side.

 - Rename deprecated unit32 fields, they will be ignored by current and future agent in favor of new int64
 - Add a field so that an agent can inform the server it is recent and supports files/ranges over 2GB
 - Block request whose range is over the 2GB mark IFF the target agent is old and does not support it
 - Migrate from int to long where appropriate

Old behavior:
 1) Files smaller than 2GB: no problem
 2) Range below 2GB for larger than 2GB file: no problem
 3) Range above 2GB for larger than 2GB files: error 500, integer overflow

New behavior
 1) Unchanged
 2) Unchanged
 3) (against old agent) Unchanged (but better error message)
 3) (against new agent) successful

Run Details

19 of 19 new or added lines in 3 files covered. (100.0%)

14583 of 15651 relevant lines covered (93.18%)

0.93 hits per line