Nebo15 / logger_json

100%

master: 100%

LAST BUILD ON BRANCH cd/encode-error-metadata-upstream

branch: cd/encode-error-metadata-upstream

CHANGE BRANCH

x

Reset

• cd/encode-error-metadata-upstream
• 0.2.0
• 0.3.0
• 0.4.0
• 0.5.0
• 1.1.0
• 1.2.0
• 1.3.0
• 2.0.1
• 3.0.1
• 3.0.2
• 3.0.3
• 3.1.0
• 3.1.1
• 3.1.2
• 3.2.0
• 3.3.0
• 4.0.0
• 4.1.0
• 4.2.0
• 5.0.0
• 5.1.0
• 5.1.1
• 5.1.2
• al/datadog-error-tracker
• fix-warning-on-binary-matching
• fix/format-affected-user-with-integer-values
• fix/render-file-as-string
• master
• patch-1
• refs/pull/146/merge
• use-json-elixir-1-18

Build # 16f11024515e953d24c810357d706a5220bf3238-PR-174

Build Type

Pull #174

github

Committed by doughsay

Commit Message

fix(datadog): Encode metadata error value before embedding in error field

format_error/4 embedded the raw metadata :error value into the log line,
bypassing RedactorEncoder. A non-JSON-encodable term (e.g. an {:error,
reason} tuple) then crashed the encoder, and because maybe_merge is
left-biased the encoded copy of the metadata could not overwrite it. The
formatter crash surfaces as "FORMATTER CRASH: ..." fallback lines and the
original log event is lost entirely.

Run the value through encode/2 (which also applies redactors), matching
how every other part of the line is built.

Pull Request Pull Request #174: fix(datadog): Encode metadata error value before embedding in error field

Coverage Stats

4 of 4 new or added lines in 1 file covered. (100.0%)

380 of 380 relevant lines covered (100.0%)

2163.1 hits per line