NaturalHistoryMuseum / iiif-image-server

88%

main: 88%

LAST BUILD ON BRANCH josh/rotate_images

branch: josh/rotate_images

CHANGE BRANCH

x

Reset

• josh/rotate_images
• dev
• ginger/tiffs
• ginger/timeouts
• josh/actions
• josh/add_extras_to_info_json
• josh/bomb_errors_plus_loky
• josh/change_cache_lib
• josh/deleted-temp-files
• josh/extra_logs
• josh/file_management
• josh/fix-use-before-defined-error
• josh/fix_image_magick_seg_fault
• josh/fix_rotation
• josh/fix_rotation_artefacts
• josh/fix_seg_fault_issue
• josh/fix_tile_sizes
• josh/homeland
• josh/leaks
• josh/mam_redirects
• josh/memory_leaks
• josh/modernise
• josh/preps
• josh/remove-cors
• josh/remove_jpeg_option
• josh/rotate-images
• josh/spelling
• josh/swap_mss_irn_for_guid
• josh/update-action-runs-on
• josh/update-workflow
• josh/upgrade_dependencies
• main
• master
• patch
• v0.10.2
• v0.10.3
• v0.10.4
• v0.11.0
• v0.12.0
• v0.12.1
• v0.13
• v0.14
• v0.14.1
• v0.15.0
• v0.16.0
• v0.16.1
• v0.16.2
• v0.16.3
• v0.17.0

Build # 10031283355

Build Type

Pull #51

github

Committed by jrdh

Commit Message

fix: make sure the image is loaded before rotating it based on exif

If the first thing we do after lazily opening the image is call exif_transpose, we end up causing some issues with that functions logic. Specifically, TIFF images with a TIFF tag orientation will be double rotated because the exif_transpose function reads the TIFF tag orientation (in Pillow exif also includes these TIFF tags) before the image is loaded into memory, but once the image is loaded into memory the TIFF plugin will rotate the image based on the TIFF orientation tag before the exif_transpose function then also rotates it. To avoid this, do something else which will force the image to be loaded into memory before calling exif_transpose. Bit hacky but hey tis what it is.

Pull Request Pull Request #51: fix: rotate images on source acquisition

Run Details

2 of 2 new or added lines in 1 file covered. (100.0%)

965 of 1094 relevant lines covered (88.21%)

0.88 hits per line