NaturalHistoryMuseum / iiif-image-server

89%

main: 88%

LAST BUILD ON BRANCH josh/fix_image_magick_seg_fault

branch: josh/fix_image_magick_seg_fault

CHANGE BRANCH

x

Reset

• josh/fix_image_magick_seg_fault
• dev
• ginger/standardisation
• ginger/tiffs
• ginger/timeout-error
• ginger/timeouts
• josh/actions
• josh/add_extras_to_info_json
• josh/bomb_errors_plus_loky
• josh/change_cache_lib
• josh/deleted-temp-files
• josh/extra_logs
• josh/file_management
• josh/fix-use-before-defined-error
• josh/fix_rotation
• josh/fix_rotation_artefacts
• josh/fix_seg_fault_issue
• josh/fix_tile_sizes
• josh/homeland
• josh/leaks
• josh/mam_redirects
• josh/memory_leaks
• josh/modernise
• josh/preps
• josh/remove-cors
• josh/remove_jpeg_option
• josh/rotate-images
• josh/rotate_images
• josh/spelling
• josh/swap_mss_irn_for_guid
• josh/update-action-runs-on
• josh/update-workflow
• josh/upgrade_dependencies
• main
• master
• patch
• v0.10.2
• v0.10.3
• v0.10.4
• v0.11.0
• v0.12.0
• v0.12.1
• v0.13
• v0.14
• v0.14.1
• v0.15.0
• v0.16.0
• v0.16.1
• v0.16.2
• v0.16.3
• v0.17.0
• v1.0.0
• v1.0.1

Build # 6884372600

Build Type

Pull #43

github

Committed by jrdh

Commit Message

fix: remove image magick from jpg conversion code

Found a tiff which when converted just causes a seg fault from Image Magick due to an assertion error. Not sure why this happens so let's just remove Image Magick from the convert function and in turn just remove it completely from the project as this was the only place it was being used.
Shame as it was faster than pillow, hence why it was there, but you can't catch a seg fault and without knowing why the image is causing this problem, this is the best option right now.

Closes #41

Pull Request Pull Request #43: Remove image magick from jpg conversion code

Run Details

12 of 12 new or added lines in 1 file covered. (100.0%)

915 of 1030 relevant lines covered (88.83%)

0.89 hits per line