NaturalHistoryMuseum / ckanext-versioned-datastore

69%

main: 72%

LAST BUILD ON BRANCH josh/guard_xlsx_save

branch: josh/guard_xlsx_save

CHANGE BRANCH

x

Reset

• josh/guard_xlsx_save
• HEAD
• ckan-2.9.5
• ckan-2.9.6
• dev
• ginger/autocomplete
• ginger/citation-version
• ginger/ckantools
• ginger/ckantools-0.0.4
• ginger/community-health
• ginger/deprecate-ckanpackager
• ginger/docker-compose-cmd
• ginger/download-init-hook
• ginger/downloads-v2
• ginger/eml-fixes
• ginger/eml-title
• ginger/faster-resource-check
• ginger/gabby-fixes
• ginger/ignore-missing
• ginger/ignore-missing-resources
• ginger/init-nav-slugs
• ginger/multi-resource-slug
• ginger/notifier-failing
• ginger/query-doi-versions
• ginger/remove-excel
• ginger/resource-exists
• ginger/rtd-config-update
• ginger/scrolling-query
• ginger/single-email-popup
• ginger/single-item-or
• ginger/skip-empty-rows
• ginger/slugerator
• ginger/sort-version
• ginger/standardisation
• ginger/standardise
• ginger/status
• ginger/status-cache
• ginger/status-patches
• ginger/sync-branch-workflow
• ginger/update-api-docs
• ginger/update-logos
• ginger/vernacular-dwc
• ginger/version-helpers
• ginger/zero-hit-resources
• josh/add_datastore_multisearch_counts_action
• josh/add_some_more_req_tests
• josh/catch-xlsx-null
• josh/ckan-2.10
• josh/datastore_get_resource_versions_perf
• josh/deduplicate_resource_ids
• josh/download_filter_out_none_counts
• josh/fix-docker-postgres-start-error
• josh/fix-long-http-line-in-es-error
• josh/fix-multi-count-logic-error
• josh/fix-query-dois-error
• josh/fix-typo-on-datastore-page
• josh/fix_custom_download_filename_missing
• josh/preps
• josh/records_validation
• josh/update-splitgill
• josh/use_ckantest_image
• josh/vds_multi_direct
• main
• patch

Build # #449

Build Type

Pull #143

coveralls-python

Committed by jrdh

Commit Message

fix: ensure the workbook is closed if something goes wrong during the write call

I'm not 100% sure this catches the problem as I couldn't recreate it locally (it must be an error at a very specific point or something?) but this has a decent chance of fixing the problem of a temporary workbook being left around in /tmp after we've finished/errored the download.

Closes: #118

Pull Request Pull Request #143: fix: ensure the workbook is closed if something goes wrong during the write call

Run Details

3 of 3 new or added lines in 1 file covered. (100.0%)

14 existing lines in 3 files now uncovered.

2846 of 4113 relevant lines covered (69.2%)

0.69 hits per line