NaturalHistoryMuseum / ckanext-statistics

58%

main: 74%

LAST BUILD ON BRANCH josh/fix_numbers

branch: josh/fix_numbers

CHANGE BRANCH

x

Reset

• josh/fix_numbers
• HEAD
• ckan-upgrade-2.8.0a
• dev
• ginger/citation-version
• ginger/community-health
• ginger/dependencies
• ginger/deprecate-ckanpackager
• ginger/docker-compose-cmd
• ginger/gabby-fixes
• ginger/gbif-stats
• ginger/handle-none
• ginger/include-migration
• ginger/merge-commit-type
• ginger/python-setup-version
• ginger/readme
• ginger/rtd-config-update
• ginger/standardisation
• ginger/standardise
• ginger/sync-branch-workflow
• ginger/update-logos
• ginger/vds-downloads-compatibility
• josh/add_new_stats
• josh/catch_count_error
• josh/ckan-upgrade-2.9
• josh/copy-ckanpackager-model
• josh/fix-docker-postgres-start-error
• josh/fix_stats_requests
• main
• master
• patch
• v2.0.0
• v2.0.1

Build # 18

Build Type

Pull #5

travis-ci

Committed by web-flow

Commit Message

Improve stats datastore counting

We were using this check:

  resource[u'url_type'] in [u'datastore', u'upload', u'dataset']

which had to be passed before we'd ask the datastore what the count
on the resource was, however if you don't upload the data (for example
you link to an external URL source) then this fails even though the
datastore will have ingested the data. This has been removed in favour
of checking the datastore_active property of the resource.

Secondly, this commit just tidies up some of the logic, most notably
we don't just get the first 200 packages, we get all of them,
iteratively.

Pull Request Pull Request #5: Improve stats datastore counting

Run Details

20 of 20 new or added lines in 1 file covered. (100.0%)

187 of 321 relevant lines covered (58.26%)

0.58 hits per line