NaturalHistoryMuseum / ckanext-nhm

33%

main: 33%

LAST BUILD ON BRANCH josh/fix-old-gallery-view

branch: josh/fix-old-gallery-view

CHANGE BRANCH

x

Reset

• josh/fix-old-gallery-view
• main
• dev
• ginger/standardise
• HEAD
• josh/sort_record_stats_page
• josh/show_extension_versions
• sarah/contact-form-insects-temporary-change
• ginger/vds-downloads-compatibility
• sarah/image-citation
• ginger/featured-dataset
• ginger/dwc-links
• ginger/dependabot
• josh/remove_exclamation_mark
• ginger/gbif-issues-filter
• josh/contact_changes
• ginger/gabby-fixes
• ginger/preset-patch
• sarah/contact-form-address-insects-reset
• ginger/search-fields
• ginger/old-versions
• ginger/broken-imgs
• ginger/slug-editor-fix
• ginger/gallery-async-loading
• sarah/remove-eees-contact-form-options
• patch
• ginger/sync-branch-workflow
• josh/allow_user_subject
• josh/fix-docker-postgres-start-error
• ginger/date-columns
• ginger/image-viewer-bug
• josh/switch-out-uv-for-mirador
• ginger/deprecate-ckanpackager
• josh/fix-p10k-api-error
• josh/external-links-safe
• ginger/botany-contact
• ginger/gallery-fix
• ginger/new-brand
• ginger/update-logos
• ginger/mobile-header
• ui-fixes
• ginger/brand-tweaks
• ginger/download-validation
• ginger/gallery-bugs
• ginger/analytics
• josh/ckan-2.10
• ginger/credits
• josh/fix_empty_datastore_version_bug
• ginger/grid-order
• ginger/community-health
• ginger/citation-version
• ginger/eml-fixes
• ginger/fields
• ginger/groups
• ginger/image-download-url
• josh/reinstate_google_analytics
• ginger/term-editor-dismiss
• ginger/beetle-viewer-updates
• ginger/goodbye-x-formerly-known-as-twitter
• ginger/image-refresh
• ginger/bibtex
• ginger/rtd-config-update
• ginger/gallery-bug
• josh/datacite_page
• ginger/aphids
• ginger/iiif-originals
• ginger/column-picker
• ginger/gallery-update
• ginger/aohc
• ginger/search-fixes
• ginger/insects-contact
• ginger/image-filter-load
• josh/allow_json-ld_format
• ginger/liv
• ginger/fix-docs
• josh/gbif_api_timeout
• ginger/record-image-id
• ginger/password-button
• ginger/more-liv-links
• ginger/orgs
• josh/fix_geo_record_parsing
• ginger/no-org
• ginger/status
• ginger/maintainer
• ginger/bii-contact
• ginger/help-footer
• ginger/mss-status
• josh/minor_bbcm_changes
• ginger/status-bugs
• ginger/legal
• ginger/footer
• ginger/record-version
• ginger/nofollow
• ginger/docker-compose-cmd

Build # #696

Build Type

Pull #724

coveralls-python

Committed by jrdh

Commit Message

fix: include base/view-filters in all assets that require it to ensure ckan.views is available

This fixes the old gallery view not being interactive. I'm not exactly sure why but I think it caused some of our code to fail to initialise properly and then the click events were just being missed. Not sure why this suddenly stopped working either? Bit weird but heyho.
It is likely not all of these assets need base/view-filters, I just added it to every asset which included a JS file which references ckan.views to be safe.

Closes: #723

Pull Request Pull Request #724: Include `base/view-filters` in all assets that require it to ensure `ckan.views` is available

Run Details

761 of 2313 relevant lines covered (32.9%)

0.33 hits per line