NaturalHistoryMuseum / ckanext-nhm

33%

main: 33%

LAST BUILD ON BRANCH ginger/record-image-id

branch: ginger/record-image-id

CHANGE BRANCH

x

Reset

• ginger/record-image-id
• HEAD
• dev
• ginger/analytics
• ginger/aohc
• ginger/aphid-text
• ginger/aphids
• ginger/api-limits
• ginger/beetle-viewer-updates
• ginger/bibtex
• ginger/bii-contact
• ginger/botany-contact
• ginger/brand-tweaks
• ginger/broken-imgs
• ginger/citation-version
• ginger/collection-link
• ginger/column-picker
• ginger/community-health
• ginger/credits
• ginger/dataset-visibility
• ginger/date-columns
• ginger/dependabot
• ginger/deprecate-ckanpackager
• ginger/docker-compose-cmd
• ginger/download-validation
• ginger/dwc-links
• ginger/eml-fixes
• ginger/featured-dataset
• ginger/fields
• ginger/fix-docs
• ginger/footer
• ginger/gabby-fixes
• ginger/gallery-async-loading
• ginger/gallery-bug
• ginger/gallery-bugs
• ginger/gallery-fix
• ginger/gallery-update
• ginger/gbif-issues-filter
• ginger/goodbye-x-formerly-known-as-twitter
• ginger/grid-order
• ginger/groups
• ginger/help-footer
• ginger/iiif-originals
• ginger/iiif-timeout
• ginger/image-download-url
• ginger/image-filter-load
• ginger/image-refresh
• ginger/image-viewer-bug
• ginger/insects-contact
• ginger/legal
• ginger/liv
• ginger/maintainer
• ginger/mobile-header
• ginger/more-liv-links
• ginger/mss-status
• ginger/new-brand
• ginger/no-org
• ginger/nofollow
• ginger/old-versions
• ginger/orgs
• ginger/password-button
• ginger/placeholders
• ginger/post-preps
• ginger/preset-patch
• ginger/record-version
• ginger/remove-excel
• ginger/rtd-config-update
• ginger/search-fields
• ginger/search-fixes
• ginger/search-version
• ginger/slickgrid-links
• ginger/slug-editor-fix
• ginger/slug-warnings
• ginger/standardisation
• ginger/standardise
• ginger/status
• ginger/status-bugs
• ginger/sync-branch-workflow
• ginger/term-editor-dismiss
• ginger/update-logos
• ginger/vds-downloads-compatibility
• josh/allow_json-ld_format
• josh/allow_user_subject
• josh/ckan-2.10
• josh/contact_changes
• josh/datacite_page
• josh/external-links-safe
• josh/fix-docker-postgres-start-error
• josh/fix-old-gallery-view
• josh/fix-p10k-api-error
• josh/fix_empty_datastore_version_bug
• josh/fix_geo_record_parsing
• josh/gbif_api_timeout
• josh/minor_bbcm_changes
• josh/preps
• josh/reinstate_google_analytics
• josh/remove_exclamation_mark
• josh/show_extension_versions
• josh/sort_record_stats_page
• josh/switch-out-uv-for-mirador
• main
• patch
• sarah/contact-form-address-insects-reset
• sarah/contact-form-insects-temporary-change
• sarah/image-citation
• sarah/remove-eees-contact-form-options
• ui-fixes

Build # #851

Build Type

push

coveralls-python

Committed by alycejenni

Commit Message

fix: create unique id for image associated with record

Records and images actually have a many-to-many relationship, but here it's been defined as a one-to-many; using the url as an id for the image was causing subsequent references to the same image to overwrite the previous record associations, so some records did not have any images. This also caused long loading times because the image would be requested for every record but only shown for the last.
Using an id that is unique to the resource, record, and image means that images are repeated but that's probably clearer anyway.

Run Details

775 of 2334 relevant lines covered (33.2%)

0.33 hits per line