NaturalHistoryMuseum / ckanext-ldap

50%

main: 43%

LAST BUILD ON BRANCH josh/ldap_action_not_calling_auth

branch: josh/ldap_action_not_calling_auth

CHANGE BRANCH

x

Reset

• josh/ldap_action_not_calling_auth
• 116-support-ckan-2.10
• HEAD
• ckan-upgrade-2.8.0a
• dev
• ginger/2.11
• ginger/citation-version
• ginger/community-health
• ginger/conftest
• ginger/docker-compose-cmd
• ginger/docker-latest
• ginger/docs
• ginger/error-msg
• ginger/gabby-fixes
• ginger/include-migration
• ginger/merge-commit-type
• ginger/python-setup-version
• ginger/readme
• ginger/rtd-config-update
• ginger/standardisation
• ginger/standardise
• ginger/sync-branch-workflow
• ginger/theme-folder
• ginger/update-logos
• josh/210issues
• josh/ckan-upgrade-2.9
• josh/fix-docker-postgres-start-error
• josh/fix-missing-attr-issue
• josh/fix-missing-attr-issue-backport
• josh/fix_210_tests
• josh/fix_tests
• josh/run_210_tests_too
• josh/test_on_210
• main
• master
• patch
• v2.1.0
• v3.0.0

Build # 48

Build Type

Pull #58

travis-ci

Committed by web-flow

Commit Message

Prevent an exception being thrown due to context reuse

If you reuse a context dict after it is used on a failed call you may
get an exception like this: "Action function <action> did not call its
auth function". This is what was happening here where we used the action
"organization_show" to check if the organisation already existed or not
and then if it didn't, create it. The context is reused so the auth
check exception was thrown. Simply removing the auth audit solves the
problem. This PR on ckanext-harvest exhibits the same problem:
https://github.com/ckan/ckanext-harvest/issues/84 and it is fixed in the
same way as we do in this commit, in this commit on ckanext-harvest:
https://github.com/ckan/ckanext-harvest/commit/f315f41c8.

Pull Request Pull Request #58: Prevent an exception being thrown due to context reuse

Run Details

2 of 4 relevant lines covered (50.0%)

0.5 hits per line