NVIDIA / holodeck
53%
main: 50%

LAST BUILD BRANCH: pull-request/878
DEFAULT BRANCH: main
Repo Added
Token cxHyzDX7QhkphvrIrXZpMb8dE7nTLCIjl regen
Build 1692 Last
Files 84
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH pull-request/878
branch: pull-request/878
CHANGE BRANCH
x
Sync Branches

coverage: 53.213% (+0.07%) from 53.143%
37519464677

push

github

abrarshivani 
fix(aws): fall back to AWS zone placement without zone discovery permissions

The availability zone pre-flight calls DescribeAvailabilityZones and
DescribeInstanceTypeOfferings. An identity without the
ec2:DescribeAvailabilityZones or ec2:DescribeInstanceTypeOfferings
permission gets UnauthorizedOperation from those calls, which aborted the
pre-flight, so callers that could create environments before the zone
selection change could no longer create anything. The real-AWS CI user is
one of them.

When either call fails with UnauthorizedOperation and no availabilityZone
is set, the pre-flight now logs a warning naming both permissions and
leaves the zone unselected, and createSubnet and createPublicSubnet omit
AvailabilityZone so that AWS chooses it as before. The region-level
instance type check still runs, and dryrun behaves the same way. If
availabilityZone is set, the pre-flight fails instead, because the
requested zone cannot be validated without those permissions. Any other
error from the zone discovery calls still fails the pre-flight.

The subnet functions still refuse an empty zone unless the pre-flight
recorded this fallback, so a path that skips the pre-flight cannot
silently let AWS pick the zone. The error code is read through the
ErrorCode method that smithy.APIError defines, which keeps smithy-go an
indirect dependency.

The prerequisites page lists the two permissions as recommended and
describes what happens without them.

Signed-off-by: Abrar Shivani <ashivani@nvidia.com>

34 of 34 new or added lines in 2 files covered. (100.0%)

7122 of 13384 relevant lines covered (53.21%)

0.59 hits per line

Relevant lines Covered
13384 RELEVANT LINES 7122 COVERED LINES
0.59 HITS PER LINE
Source Files on pull-request/878

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
37519464677 pull-request/878 fix(aws): fall back to AWS zone placement without zone discovery permissions The availability zone pre-flight calls DescribeAvailabilityZones and DescribeInstanceTypeOfferings. An identity without the ec2:DescribeAvailabilityZones or ec2:Describe... push abrarshivani github
53.21
37386942299 pull-request/878 feat(aws): record the selected availability zone in status The zone chosen by the pre-flight only appeared in the create log. Store it as an availability-zone property in .status.properties, next to the VPC and subnet IDs, for both single-node en... push abrarshivani github
53.14
See All Builds (1660)

Badge your Repo: holodeck

We detected this repo isn’t badged! Grab the embed code to the right, add it to your repo to show off your code coverage, and when the badge is live hit the refresh button to remove this message.
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

Refresh