|
Repo Added
|
Files
125
|
Badge
README BADGES
|
github
fix[device-plugin] add DEVICE_LIST_STRATEGY env var guardrail This commit adds additional validation to the devicePlugin operand transformation logic. When CDI is enabled, it is required that the DEVICE_LIST_STRATEGY env var value includes one of "cdi-annotations" and "cdi-cri". While the current transformation code adds these values to DEVICE_LIST_STRATEGY when .spec.cdi.enabled is true, the same resolved value gets overridden when the gpu-operator user sets the DEVICE_LIST_STRATEGY env var explicitly in the devicePlugin section of the ClusterPolicy custom resource. This changes addresses a major limitation in the gpu-operator where feedback from an invalid devicePlugin config only happens at gpu pod workload scheduling which is a significant delay. This provides a poor UX as users waste hours debugging the containerCreate failures instead of identifying the invalid devicePlugin config. This fix changes that by failing at the ClusterPolicy reconcile stage. Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com> (cherry picked from commit 54cc02c0e)
12 of 12 new or added lines in 1 file covered. (100.0%)
5720 of 14588 relevant lines covered (39.21%)
0.45 hits per line
| Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line |
|---|