NVIDIA / gpu-operator
45%
main: 45%

LAST BUILD BRANCH: pull-request/3089
DEFAULT BRANCH: main
Repo Added
Files 75
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH pull-request/3044
branch: pull-request/3044
CHANGE BRANCH
x

coverage: 44.983%. Remained the same
38417235473

push

github

v0ropaev 
fix: fail the node pool when its additional driver configs do not render

getManifestObjects logs the error from getDriverAdditionalConfigs and carries
on. Every other fallible step in the same loop returns it: getDriverSpec,
getGDSSpec, getGDRCopySpec, renderManifestObjects and
handleDefaultImagesInObjects. Because the call assigns into
renderData.AdditionalConfigs, the failure also leaves that field nil, and the
DaemonSet template guards every use of it with

  {{- if and .AdditionalConfigs .AdditionalConfigs.VolumeMounts }}

so the driver renders with none of the volumes the user asked for: no custom
package repo, no custom CA certificates, no kernel module parameters and no
vGPU licensing config. getDriverAdditionalConfigs only ever returns nil with
the error, so there is no partial result worth keeping.

The reconcile reports success, the NVIDIADriver goes Ready once the pods come
up, and the only trace is one log line. Nothing reaches the CR status or its
conditions. The ClusterPolicy path does not behave this way:
transformDriverContainer returns the same failure to its caller.

TestGetManifestObjectsAdditionalConfigsErrorIsLogged pinned the old behaviour,
down to a comment saying the driver is still deployed "silently without the
repo config the user asked for". It came in with #2658, which added unit tests
across internal/state, so it recorded what the code did rather than what it
should do. Renamed and flipped to assert the error.

Signed-off-by: Dmitry Voropaev <dy.voropaev@gmail.com>

1 of 1 new or added line in 1 file covered. (100.0%)

5859 of 13025 relevant lines covered (44.98%)

0.45 hits per line

Relevant lines Covered
13025 RELEVANT LINES 5859 COVERED LINES
0.45 HITS PER LINE
Source Files on pull-request/3044

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
38417235473 pull-request/3044 fix: fail the node pool when its additional driver configs do not render getManifestObjects logs the error from getDriverAdditionalConfigs and carries on. Every other fallible step in the same loop returns it: getDriverSpec, getGDSSpec, getGDRCop... push v0ropaev github
44.98
See All Builds (2865)