NVIDIA / gpu-operator
44%
main: 44%

LAST BUILD BRANCH: pull-request/2890
DEFAULT BRANCH: main
Repo Added
Files 75
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH pull-request/2889
branch: pull-request/2889
CHANGE BRANCH
x

coverage: 44.481% (+0.5%) from 44.026%
34644119998

push

github

abrarshivani 
Add unit tests for internal/conditions/gpucluster

Takes the conditions package from 64.6% to 100.0% of statements. Tests
only, no production source changed.

The tests follow the shape already used by nvidiadriver_test.go and
clusterpolicy_test.go: the controller-runtime fake client with a status
subresource for the happy paths, and interceptor.Funcs to inject a
conflict on the first status update and a plain failure on every one, so
the retry wrapper and the error return are exercised rather than restated.

Most of gpucluster.go mirrors nvidiadriver.go, so most of these tests
mirror its tests. The one place the two genuinely diverge is how the error
branch resolves status.state, and that is what the bulk of the new
assertions pin. NVIDIADriverReconciler sets status.state in memory without
persisting it and then writes conditions, so its updater has to copy the
caller's value over unconditionally. GPUClusterReconciler.updateCRStatus
persists the desired state before every SetConditionsError call, so the
stored value is already authoritative and the updater only fills it in
when empty. SetConditionsErrorStateResolution covers the four combinations
of stored and caller state, and SetConditionsReadyLeavesStateAlone covers
the ready branch, which does not touch status.state at all. Together they
fail if the two updaters are ever folded into one without accounting for
the difference.

GetError asserts apierrors.IsNotFound through the wrapper rather than only
matching the wrapper text, so a %w that regresses to %v is caught.
RetryOnConflict counts Get calls as well as update calls, which is what
actually distinguishes a refetch inside the retry loop from one hoisted
out of it.

The error logged in setConditions before the return is not asserted.
Checking it needs a log sink and the returned error already covers the
same path. The backoff policy in retry.RetryOnConflict is not asserted
either; the tests check that a conflict is retried and that a non-confli... (continued)

5767 of 12965 relevant lines covered (44.48%)

0.45 hits per line

Relevant lines Covered
12965 RELEVANT LINES 5767 COVERED LINES
0.45 HITS PER LINE
Source Files on pull-request/2889

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
34644119998 pull-request/2889 Add unit tests for internal/conditions/gpucluster Takes the conditions package from 64.6% to 100.0% of statements. Tests only, no production source changed. The tests follow the shape already used by nvidiadriver_test.go and clusterpolicy_test.g... push abrarshivani github
44.48
See All Builds (2575)