NVIDIA / gpu-operator
39%
main: 38%

LAST BUILD BRANCH: pull-request/2808
DEFAULT BRANCH: main
Repo Added
Files 73
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH pull-request/2791
branch: pull-request/2791
CHANGE BRANCH
x

coverage: 38.596% (+0.1%) from 38.466%
32760113983

Pull #2791

github

invalid-email-address 
Mount host /lib/modules for precompiled drivers on SUSE

getDriverAdditionalConfigs placed the lib-modules volume and mount inside
the "if !cr.Spec.UsePrecompiledDrivers()" branch, guarded by a check for
UsePrecompiledDrivers. That inner condition can never hold there, so an
NVIDIADriver with usePrecompiled: true on sles or sl-micro rendered a
driver pod without /run/host/lib/modules.

Move the mount out to its own block after the non-precompiled branch. The
comment above it goes as well, since the guard already says precompiled
and SUSE and the volume literals already say host module tree.

The equivalent code in the ClusterPolicy path sits before the early return
for precompiled drivers and works as intended, so only the NVIDIADriver
path was affected. That is also why this went unnoticed: the tests added
with the mount only covered the ClusterPolicy path.

Add a table-driven test that renders the DaemonSet and asserts the volume
on the pod spec and the mount on nvidia-driver-ctr. Going through the
render catches a template change that stopped threading AdditionalConfigs
into the pod as well as the Go-side bug.

Fixes #2776

Signed-off-by: Abrar Shivani <ashivani@nvidia.com>
(cherry picked from commit 77d167350)
Pull Request #2791: [release-26.7] Mount host /lib/modules for precompiled drivers on SUSE

16 of 16 new or added lines in 1 file covered. (100.0%)

5610 of 14535 relevant lines covered (38.6%)

0.44 hits per line

Relevant lines Covered
14535 RELEVANT LINES 5610 COVERED LINES
0.44 HITS PER LINE
Source Files on pull-request/2791

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
32760113983 pull-request/2791 Mount host /lib/modules for precompiled drivers on SUSE getDriverAdditionalConfigs placed the lib-modules volume and mount inside the "if !cr.Spec.UsePrecompiledDrivers()" branch, guarded by a check for UsePrecompiledDrivers. That inner condition... Pull #2791 invalid-email-address github
38.6
See All Builds (2445)