NVIDIA / gpu-operator
41%
main: 38%

LAST BUILD BRANCH: pull-request/2750
DEFAULT BRANCH: main
Repo Added
Files 73
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH pull-request/2698
branch: pull-request/2698
CHANGE BRANCH
x

coverage: 40.644%. Remained the same
30603253200

push

github

abrarshivani 
Add unit tests for api/versioned/fake clientset

Cover NewSimpleClientset and the generated fake clientset wiring: seeding
the object tracker, CRUD round trips through both group clients, the
default watch reactor delivering Added/Modified/Deleted events, action
recording and ClearActions, reactor interception and fall-through,
panicking on an object type absent from the fake scheme, Tracker being
shared with the typed clients, Discovery returning a FakeDiscovery bound
to the same Fake, IsWatchListSemanticsUnSupported, and the interface
assertions from the generated var block.

Also covers register.go: the package scheme recognising all nvidia kinds
plus the metav1 types, AddToScheme composing into a fresh scheme, and
codecs decoding both group versions.

Assertions are limited to the generated client's own contract rather than
the behaviour of the current client-go fake. DeleteCollection is asserted
through the recorded action (verb, GroupVersionResource, empty namespace,
and the DeleteOptions and ListOptions carried on it) instead of asserting
that nothing is deleted, which would pin a testing.ObjectReaction
implementation detail and break a future Kubernetes upgrade that
implemented it. That limitation is recorded in a comment, and a
reactor-backed test covers real collection deletion.

The watch test asserts the ListOptions the generated client forwards to
tracker.Watch, including the Watch field it sets itself; replay of
pre-existing objects follows from that forwarding and is kept as a
documented corollary.

The unregistered-kind panic uses a private, never-registered test type
rather than corev1.Pod, which would silently stop testing anything if core
types were ever added to this scheme, and asserts the recovered value
satisfies runtime.IsNotRegisteredError so it cannot pass for the wrong
reason. Waits are bounded by a 2s eventTimeout and contexts derive from
t.Context().

Where a behaviour belongs to client-go rather than to the generated clie... (continued)

5923 of 14573 relevant lines covered (40.64%)

0.46 hits per line

Relevant lines Covered
14573 RELEVANT LINES 5923 COVERED LINES
0.46 HITS PER LINE
Source Files on pull-request/2698

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
30603253200 pull-request/2698 Add unit tests for api/versioned/fake clientset Cover NewSimpleClientset and the generated fake clientset wiring: seeding the object tracker, CRUD round trips through both group clients, the default watch reactor delivering Added/Modified/Deleted... push abrarshivani github
40.64
30602830442 pull-request/2698 Add unit tests for api/versioned/fake clientset Cover NewSimpleClientset and the generated fake clientset wiring: seeding the object tracker, CRUD round trips through both group clients, the default watch reactor delivering Added/Modified/Deleted... push abrarshivani github
40.64
30593181003 pull-request/2698 Address review feedback for api/versioned/fake clientset tests Stop requiring upstream client-go fake limitations to hold. Asserting that DeleteCollection deletes nothing pins an implementation detail of the current testing.ObjectReaction and wou... push abrarshivani github
40.64
30590579139 pull-request/2698 Add unit tests for api/versioned/fake clientset Cover NewSimpleClientset and the generated fake clientset wiring: seeding the object tracker, CRUD round trips through both group clients, the default watch reactor delivering Added/Modified/Deleted... push abrarshivani github
40.64
See All Builds (2342)