NREL / SolTrace

89%

push

github

Sun position calcs (#83)

* adding solar position calculators

* adding initial sun position tests

* Remove unused solar calculator utility modules

Deleted lib_pv_incidence_modifier, lib_util, and lib_weatherfile modules from solar_position_calculators, and updated CMakeLists and includes accordingly. These files are no longer required for current solar position calculations (SPA).

* Add SolarPositionCalculator class and tests

Introduces SolarPositionCalculator with multiple calculation methods (LEGACY, DUFFIE, SOLPOS, SPA_ORIGINAL, SPA), input validation, and output retrieval. Updates CMakeLists and headers for integration, refactors sun position logic, and adds comprehensive unit tests for validation and cross-method consistency.

* fixing some compiler errors and warnings

* Guard M_PI definition with preprocessor check

Added a preprocessor guard to define M_PI only if it is not already defined, preventing potential redefinition errors. DTOR and RTOD constants are now always defined without constexpr.

* Update google-tests/unit-tests/simulation_data/sun_position_test.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* addressing PR comments

* Update sun_position_test.cpp

updating test value

* Update expected sun vector values in test

Adjusted the expected_sun_x value and relaxed the precision for sun_x comparison in the CrossValidationTest to reflect updated calculation results.

* minor changes

* Initialize elevation in SunPositionCalculator

* Update solar_position_calculator.cpp

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Taylor Brown <60201147+taylorbrown75@users.noreply.github.com>

996 of 1195 new or added lines in 4 files covered. (83.35%)

5492 of 6188 relevant lines covered (88.75%)

8572678.39 hits per line