NFIBrokerage / slipstream

99%

main: 99%

LAST BUILD ON BRANCH fix-broken-decode-binary

branch: fix-broken-decode-binary

CHANGE BRANCH

x

Reset

• fix-broken-decode-binary
• Slipstream.Socket.update/3
• allow-binary-frames
• broadcasts-and-binaries
• bump-github-action-versions
• client-telemetry
• conn-extra-messages-bug-squashing
• dialyzer
• example-genserver
• examples
• graceful-startup
• handle-leave-2
• handle-rejection
• heartbeat-timeout
• main
• md-assert-connect-test-helper
• md-fix-socket-mem-leak
• md-mint-websocket-0.2.0
• mint-web-socket
• patch-1
• refs/tags/v0.1.0
• refs/tags/v0.1.1
• refs/tags/v0.1.2
• refs/tags/v0.1.3
• refs/tags/v0.1.4
• refs/tags/v0.2.0
• refs/tags/v0.2.1
• refs/tags/v0.2.2
• refs/tags/v0.2.3
• refs/tags/v0.2.4
• refs/tags/v0.3.0
• refs/tags/v0.3.1
• refs/tags/v0.3.2
• refs/tags/v0.3.3
• refs/tags/v0.3.4
• refs/tags/v0.4.0
• refs/tags/v0.4.1
• refs/tags/v0.4.2
• refs/tags/v0.4.3
• refs/tags/v0.4.4
• refs/tags/v0.5.0
• refs/tags/v0.5.1
• refs/tags/v0.5.2
• refs/tags/v0.5.3
• refs/tags/v0.5.4
• refs/tags/v0.6.0
• refs/tags/v0.6.1
• refs/tags/v0.6.2
• refs/tags/v0.7.0
• refs/tags/v0.8.0
• refs/tags/v0.8.0-rc.1
• refs/tags/v0.8.1
• refs/tags/v0.8.2
• refs/tags/v0.8.3
• refs/tags/v0.8.4
• refs/tags/v0.8.5
• refs/tags/v1.0.0
• refs/tags/v1.0.1
• refs/tags/v1.0.2
• refs/tags/v1.0.3
• refs/tags/v1.0.4
• refs/tags/v1.2.0
• remove-phoenix-dependency
• repeater-example
• scripting-example
• stale-config
• telemetry-refactor-pipeline
• test-framework
• ubuntu-latest-ci-sept-20

Build # be6f551990bf33fc3b472202b2c2da0abf3aaf9e-PR-81

Build Type

Pull #81

github

Committed by bencoppock

Commit Message

Fix broken `decode_binary!`

Encoding was correct, but the pattern match for decoding wasn't
properly accounting for a couple of values that Phoenix uses.

Added a round trip test for binary encoding to verify that encode/decode
returns the original value. Also added a round trip test for non-binary
json encoding for good measure (even though it wasn't broken).

Pull Request Pull Request #81: Fix broken `decode_binary!`

Run Details

437 of 440 relevant lines covered (99.32%)

52.97 hits per line