• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

MayeulC / hb-downloader
41%
master: 58%

Build:
Build:
LAST BUILD BRANCH: poc-trove
DEFAULT BRANCH: master
Repo Added 23 Apr 2018 08:46PM UTC
Files 30
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH next
branch: next
CHANGE BRANCH
x
Reset
  • next
  • master
  • next-next
  • poc-trove
  • test-codacy
  • wip-CI
  • wip-setup

pending completion
46

push

travis-ci

MayeulC
Actually remove MD5 file

Previously os.remove was called before HumbleHash.remove_md5file. However,
remove_md5file does nothing if the file (full_filename) does not exist.
(See hb-downloader/humble_api/humble_hash.py ).

So the md5 file was never actually removed and the call to remove_md5file did
nothing.

This lead to the problem that corrupt files were always re-downloaded again
and again without updating the corresponding md5 file. (The md5 file was
never deleted and it is assumed that existing md5 files are correct and
up-to-date.)

With this commit, the md5 file is actually deleted (and recreated when
necessary). This way there are no more out-of-date md5 files.

1 of 1 new or added line in 1 file covered. (100.0%)

339 of 827 relevant lines covered (40.99%)

0.41 hits per line

Relevant lines Covered
Build:
Build:
827 RELEVANT LINES 339 COVERED LINES
0.41 HITS PER LINE
Source Files on next
  • List 0
  • Changed 1
  • Source Changed 1
  • Coverage Changed 0
Coverage ∆ File Lines Relevant Covered Missed Hits/Line

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
46 next Actually remove MD5 file Previously os.remove was called before HumbleHash.remove_md5file. However, remove_md5file does nothing if the file (full_filename) does not exist. (See hb-downloader/humble_api/humble_hash.py ). So the md5 file was never... push 06 Jan 2019 08:49PM UTC MayeulC travis-ci pending completion  
43 next add Dockerfile push 06 Jan 2019 08:37PM UTC MayeulC travis-ci pending completion  
29 next Change two humble_api methods to static methods push 21 Jul 2018 07:38PM UTC MayeulC travis-ci pending completion  
24 next Ignore the test/ directory during coverage trough a .coveragerc file push 18 Jun 2018 06:01PM UTC MayeulC travis-ci pending completion  
See All Builds (37)
  • Repo on GitHub
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc