MITLibraries / transmogrifier

99%

main: 99%

LAST BUILD ON BRANCH TIMX-355-control-field-index

branch: TIMX-355-control-field-index

CHANGE BRANCH

x

Reset

• TIMX-355-control-field-index
• rdi-52
• main
• jpal-transform
• proposed-transform
• RDI-78
• rdi-77
• RDI-53-zenodo-transform
• makefile-workflow-updates
• stage-workflow-update
• rdi-106-complete-timdex-record-model
• RDI-55-whoas-transform
• rdi-120-dspace-mets-transform
• workflow-makefile-updates
• RDI-141-citation-generation-refactor
• rdi-160-update-config
• rdi-139-streaming-xml-parser
• RDI-111-subject-grouping
• RDI-151-datacite-refactor
• rdi-165-refactor-sources
• dependabot/pip/lxml-4.9.1
• RDI-166-record-filtering
• rdi-187-handle-missing-title-field
• RDI-216-default-content-type
• rdi-233-subfield-bugfix
• rdi-243-246-update-content-type-filters
• dependency-updates
• refs/tags/v1.0
• TIMX-64-ead-transform
• TIMX-64-ead-transform-get-optional-fields
• timx-64-refactor-class-methods-archdesc-check
• TIMX-18-marc-transform
• TIMX-64-additional-fields
• TIMX-64-add-more-fields-to-get-optional-fields
• TIMX-64-expand-get-optional-fields
• TIMX-18-marc-transform-initial_methods
• TIMX-64-complete-get-optional-fields
• TIMX-18-marc-transform-initial-methods
• TIMX-18-marc-transform-additional-fields
• TIMX-18-marc-transform-more-fields
• TIMX-18-marc-transform-even-more-fields
• TIMX-18-marc-transform-yet-more-fields
• timx-126-skip-deleted-records
• TIMX-18-dates-languages-fields
• dependabot/pip/certifi-2022.12.7
• refs/tags/v1.1.0
• TIMX-18-holdings-field
• TIMX-18-serial-holdings-field
• dependabot/pip/gitpython-3.1.30
• TIMX-18-holdings-refactor
• timx-141-deleted-records
• bugfix
• refs/tags/v1.1.1
• TIMX-180-date-cleanup
• timx-184-marc-portfolio-mapping
• timx-193-reduce-logs
• dependabot/pip/pytest-7.2.2
• dependabot/pip/mypy-1.1.1
• fix-bs4-recursion-issue
• fix-recursion-bug
• refs/tags/v1.2.1
• dependabot/pip/bandit-1.7.5
• date-whitespace-bug-fix
• update-caller-workflows
• TIMX-212-invalid-date-bug-fix
• TIMX-212-invalid-date-fix
• dependabot/pip/sentry-sdk-1.17.0
• dependabot/pip/beautifulsoup4-4.12.0
• dependabot/pip/black-23.3.0
• dependabot/pip/sentry-sdk-1.18.0
• dependency-updates-23-03-29
• refs/tags/v1.2.2
• dependabot/pip/sentry-sdk-1.19.0
• dependabot/pip/sentry-sdk-1.19.1
• dependabot/pip/beautifulsoup4-4.12.1
• dependabot/pip/mypy-1.2.0
• dependabot/pip/beautifulsoup4-4.12.2
• dependabot/pip/pytest-7.3.0
• dependabot-update
• dependabot/pip/attrs-23.1.0
• dependabot/pip/pytest-7.3.1
• dependabot/pip/sentry-sdk-1.20.0
• dependabot/pip/sentry-sdk-1.21.0
• dependabot/pip/sentry-sdk-1.21.1
• dependabot/pip/sentry-sdk-1.22.1
• dependabot/pip/mypy-1.3.0
• dependabot/pip/sentry-sdk-1.22.2
• dependabot/pip/sentry-sdk-1.23.1
• dependabot/pip/requests-2.31.0
• refs/heads/dependabot/pip/sentry-sdk-1.24.0
• dependabot/pip/sentry-sdk-1.25.0
• dependabot/pip/sentry-sdk-1.25.1
• dependabot/pip/pytest-7.3.2
• dependabot/pip/mypy-1.4.1
• dependabot/pip/sentry-sdk-1.26.0
• dependabot/pip/pytest-7.4.0
• dependabot/pip/lxml-4.9.3
• dependabot/pip/sentry-sdk-1.27.1
• dependencies-update
• dependabot/pip/sentry-sdk-1.28.1
• dependabot/pip/click-8.1.5
• helpers_typing
• helpers-typing
• dependabot/pip/click-8.1.6
• dependabot/pip/certifi-2023.7.22
• TIMX-227-springshare-sources
• dependabot/pip/flake8-6.1.0
• refs/tags/v1.3.0
• TIMX-232-springshare-ids
• refs/tags/v.1.3.1
• TIMX-234-update-aspace-identifiers
• refs/tags/v1.3.2
• TIMX-235-aspace-date-range
• refs/tags/v1.3.3
• TIMX-241-springshare-oai-dates
• refs/tags/v.1.3.4
• TIMX-246-methods-for-fields-adr
• GDT-82-transformer-base-class
• gdt-82-transformer-class-refactor
• GDT-83-jsontransformer
• gdt-54-aardvark-transform
• GDT-54-additional-aardvark-fields
• GDT-54-more-MITAardvark-methods
• mit-timdex-json-schema
• GDT-54-workarounds-and-bug-fixes
• gdt-116-update-locations
• GDT-138-update-timdex-record-to-enable-access-filter
• GDT-149-updates-from-full-mit-harvest
• linting-update
• add-description-to-readme
• GDT-68-update-external-url
• dependabot/pip/sentry-sdk-1.40.3
• dependabot/pip/pre-commit-3.6.1
• dependabot/pip/ruff-0.2.1
• dependabot/pip/ipython-8.21.0
• dependabot/docker/python-3.12-slim
• GDT-109-mitaardvark-adjustments
• GDT-193-adr-handle-data-forms
• dependabot/pip/cryptography-42.0.2
• dependabot/pip/ruff-0.2.2
• dependabot/pip/sentry-sdk-1.40.4
• dependabot/pip/pre-commit-3.6.2
• dependabot/pip/cryptography-42.0.4
• dependabot/pip/sentry-sdk-1.40.5
• gdt-199-publication-adr
• GDT-205-adr-institution-information
• dependabot/pip/pytest-8.0.2
• GDT-201-data-type-refactor
• GDT-203-add-provider-field
• GDT-206-add-provider-field
• dependabot/pip/ruff-0.3.0
• dependabot/pip/pytest-8.1.0
• dependabot/pip/python-dateutil-2.9.0.post0
• GDT-210-publishers-refactor
• dependabot/pip/mypy-1.9.0
• dependabot/pip/ipython-8.22.2
• dependabot/pip/ruff-0.3.2
• dependabot/pip/pytest-8.1.1
• GDT-217-map-spatial-subjects-to-locations-field
• GDT-217-handle-none-values
• dependabot/pip/ruff-0.3.3
• dependabot/pip/sentry-sdk-1.42.0
• dependabot/pip/black-24.3.0
• dependabot/pip/types-python-dateutil-2.9.0.20240316
• dependabot/pip/smart-open-7.0.3
• dependabot/pip/ruff-0.3.4
• dependabot/pip/sentry-sdk-1.43.0
• dependabot/pip/pre-commit-3.7.0
• GDT-247-update-rights-access-values
• dependabot/pip/lxml-5.2.0
• dependabot/pip/ipython-8.23.0
• dependabot/pip/sentry-sdk-1.44.0
• refs/tags/v1.4.0
• TIMX-270-date-bug-fix
• refs/tags/v1.4.1
• dependabot/pip/idna-3.7
• dependabot/pip/ruff-0.3.7
• dependabot/pip/sentry-sdk-1.45.0
• dependabot/pip/black-24.4.0
• dependabot/pip/ruff-0.4.1
• field-method-refactor
• timx-273-structure-exploration
• dependabot/pip/black-24.4.2
• dependabot/pip/mypy-1.10.0
• dependabot/pip/ruff-0.4.2
• dependabot/pip/sentry-sdk-2.0.1
• dependabot/pip/ruff-0.4.3
• dependabot/pip/jinja2-3.1.4
• field-method-adr
• TIMX-284-datacite-field-method-refactor
• TIMX-283-springshare-field-method-refactor
• TIMX-287-ead-field-method-refactor
• TIMX-284-datacite-fmr-strikes-back
• TIMX-287-ead-field-method-refactor-1
• TIMX-287-ead-field-method-refactor-2
• TIMX-284-datacite-fmr-beyond-thunderdome
• TIMX-287-ead-field-method-refactor-3
• TIMX-286-dspace-mets-fmr-begins
• TIMX-287-ead-field-method-refactor-4
• TIMX-286-dspace-mets-fmr-returns
• TIMX-282-dspacedim-fmr-origins
• TIMX-282-dspacedim-fmr-judgment-day
• TIMX-285-aardvark-fmr
• TIMX-285-aardvark-fmr-the-wrong-trousers
• TIMX-288-marc-field-method-refactor
• TIMX-288-marc-field-method-refactor-2
• TIMX-288-marc-field-method-refactor-3
• TIMX-288-marc-field-method-refactor-4
• TIMX-288-marc-field-method-refactor-5
• TIMX-291-orchestration
• TIMX-332-dedupe-function
• IN-1079-maintenance-2024-10
• TIMX-400-new-popupvinyl-location

Build # 11615044039

Build Type

Pull #208

github

Committed by ghukill

Commit Message

Address liteary form control field bug

Why these changes are being introduced:

There is at least one MARC record that comes through
where control field 008 is not 34 characters, and therefore
was throwing an error when we attempt to grab the 33rd character.

How this addresses that need:
* If control field 008 is < 34 chars, return None for literary form

Side effects of this change:
* Transmogrifier runs for large swaths of files, e.g. full runs, will
not catastrophically fail for this single bug.
* This might suggest another layer of error handling to avoid full
run failure for a single record, will create at ticket for this.

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/TIMX-355

Pull Request Pull Request #208: Address liteary form control field bug

Run Details

4 of 4 new or added lines in 1 file covered. (100.0%)

1659 of 1668 relevant lines covered (99.46%)

0.99 hits per line