MITLibraries / python-cli-template

100%

main: 100%

LAST BUILD ON BRANCH IN-1240-pip-audit

branch: IN-1240-pip-audit

CHANGE BRANCH

x

Reset

Sync Branches

• IN-1240-pip-audit
• IN-1086-maintenance-11-2024
• IN-1425-uv
• IN-894-remove-pipfile-lock
• IN-894-update-config-and-linting-defaults
• add-help-cmd-to-makefile
• create-repo-structure
• dependabot/pip/mypy-1.6.0
• dependabot/pip/pyflakes-2.5.0
• dependabot/pip/ruff-0.0.292
• dependabot/pip/sentry-sdk-1.32.0
• dependabot/pip/urllib3-2.0.6
• main
• pr-template-update
• replace-pr-template-checklist
• ruff-pyproject-toml-updates
• unpin-pyflakes
• update-dependabot-config
• update-initial-app-name
• update-pr-template
• update-readme-and-makefile

Build # 14837679861

Build Type

push

github

Committed by ghukill

Commit Message

Replace pipenv check with pip-audit

Why these changes are being introduced:

As of pipenv 2025.0.1 the use of `pipenv check` would throw
an error, indicating that the library `safety` was not installed.
It worked to run `pipenv check --auto-install` which would
temporarily install `safety`, but this was not ideal for multiple
reasons.

First, we anticipate potentially moving away from `pipenv`.

Second, it appears that `safety` is moving to a pay / subscription
model.

Third, it remains a little obfuscated what `pipenv check` is actually
doing.

As this new situation affects all builds in Github Actions CI,
we need a way to scan for vulnerabilities that ideally is not
a massive overhaul of our vulnerability scanning approach.

How this addresses that need:

`pip-audit` is a nice standalone, open-source library that
performs very similar work to `safety`.

This commit replaces `pipenv check` (which was `safety` under
the hood) with `pip-audit`.

Side effects of this change:
* Builds will be successful in Github Actions

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/IN-1240

Run Details

35 of 35 relevant lines covered (100.0%)

1.0 hits per line