Kyorai / cuttlefish

90%

develop: 90%

LAST BUILD ON BRANCH mk-repurpose-dash-a-switch

branch: mk-repurpose-dash-a-switch

CHANGE BRANCH

x

Reset

• mk-repurpose-dash-a-switch
• appvoyer-badge
• develop
• gh-1-line-with-whitespace-only
• integrations
• integrations-take-2
• lager-3.7.x
• lrb-action-status
• lrb-windows-build
• master
• mk-erlang-24-compat
• mk-switch-to-otp-logger
• prepare-2.2.0
• v2.2.0
• v2.2.1
• v2.3.0
• v2.4.0
• v2.4.1
• v2.5.0
• v2.6.0
• v2.7.0
• v3.0.0
• v3.0.1

Build # 24

Build Type

Pull #5

travis-ci

Committed by web-flow

Commit Message

Repurpose -a to mean --advanced_conf_file as --app_config is not actually used

Currently the -a flag is not used. Originally introduced in [1],
it [seemingly] was meant to allow for app.config location customization.
That never materialized as the flag is not used anywhere in the codebase
besides the getopt definition.

Instead we repurpose -a to mean --advanced_conf_file, which was adopted
in a fork currently bundled with RabbitMQ. Having a hardcoded location
for advanced.config is primarily inconvenient in integration tests
that generate configuration files.

Note that --app_config has been removed. The version will be bumped to
2.3.0.

Per discussion with @dcorbacho @kjnilsson @lukebakken.

1. 
https://github.com/basho/cuttlefish/commit/106b8b769

Pull Request Pull Request #5: Repurpose -a to mean --advanced_conf_file as --app_config is unused

Run Details

5 of 5 new or added lines in 1 file covered. (100.0%)

2406 of 2679 relevant lines covered (89.81%)

5077.76 hits per line