JuliaMathias / moolah

4%

LAST BUILD ON BRANCH main

branch: main

CHANGE BRANCH

x

Reset

• main
• 12-enhance-account-model-with-account-types
• 13-budget-category-system
• 14-life-area-category-hierarchy
• 15-create-tag-system
• 16-create-transaction-wrapper-model
• 17-create-core-investment-resource
• 18-create-investment-history-operations-tracking
• 20251209-update-dependencies
• codex/agent-env-setup
• copilot/increase-test-coverage
• copilot/increase-test-coverage-excoveralls
• copilot/set-up-copilot-instructions
• handle-beacon
• improve-copilot-setup
• renovate/actions-cache-5.x
• renovate/actions-checkout-5.x
• renovate/actions-checkout-6.x
• renovate/ash-3.x-lockfile
• renovate/ash_admin-0.x-lockfile
• renovate/ash_authentication-4.x-lockfile
• renovate/ash_authentication_phoenix-2.x-lockfile
• renovate/ash_double_entry-1.x-lockfile
• renovate/ash_money-0.x-lockfile
• renovate/ash_oban-0.x
• renovate/ash_phoenix-2.x-lockfile
• renovate/ash_postgres-2.x-lockfile
• renovate/bandit-1.x-lockfile
• renovate/credo-1.x-lockfile
• renovate/ecto_sql-3.x-lockfile
• renovate/elixir-1.x
• renovate/erlang-28.x
• renovate/ex_cldr-2.x-lockfile
• renovate/ex_cldr_dates_times-2.x-lockfile
• renovate/heroicons-2.x
• renovate/lazy_html-0.x-lockfile
• renovate/live_debugger-0.x
• renovate/live_debugger-0.x-lockfile
• renovate/node-22.x
• renovate/node-24.x
• renovate/oban_web-2.x-lockfile
• renovate/phoenix-1.x-lockfile
• renovate/phoenix_live_reload-1.x-lockfile
• renovate/phoenix_live_view-1.x-lockfile
• renovate/postgres-18.x
• renovate/swoosh-1.x-lockfile
• renovate/tidewave-0.x
• setup-ci-and-excoveralls
• update-dependencies
• update-deps
• update-readme

Build # 438d0c353976b21477dcfd74b4fbfd9cf497aed8

Build Type

push

github

Committed by web-flow

Commit Message

Investment Transfers, Operations, and Currency Guardrails (#74)

* Create `ValidateHistoryCurrency` module for investment history validation

Adds the `Moolah.Finance.Validations.ValidateHistoryCurrency` module to ensure that investment history values use the same currency as the parent investment. The validation checks the currency of the `value` against the investment's `current_value` currency. If the investment cannot be loaded or the value is not a valid money struct, it returns `:ok`. Otherwise, it returns an error if the currencies do not match, providing a descriptive message.

* Create `ValidateOperationCurrency` module for investment operation currency validation

Ensures that the operation value currency matches the currency of the parent investment. The module loads the investment using `investment_id` and compares the operation `value` currency against the investment's `current_value` currency. Returns `:ok` if the currencies align or if the investment cannot be loaded. Returns an error message if the currencies differ, indicating that the currency must match the investment currency.

* Create `ValidateTransactionInvestmentTarget` module for transfer transaction validation

This module validates that transfer transactions target a valid investment when an investment account is involved. It enforces the following behaviors:
1. `target_investment_id` is only allowed for `:transfer` transactions.
2. If a transfer involves an investment account, `target_investment_id` is required.
3. The selected investment must belong to the investment account involved in the transfer.

The validation returns `:ok` when account or investment lookups fail, allowing relationship validations to handle missing data.

* Create `CreateInvestmentOperationFromTransaction` module for investment operation creation

Adds functionality to create investment operations for transfer transactions involving investment accounts. This module runs after a transaction is created... (continued)

Run Details

111 of 114 new or added lines in 5 files covered. (97.37%)

470 of 10977 relevant lines covered (4.28%)

1.15 hits per line