JohnMaguire / Cardinal

92%

master: 91%

LAST BUILD ON BRANCH ticker-giving-wrong-symbols

branch: ticker-giving-wrong-symbols

CHANGE BRANCH

x

Reset

• ticker-giving-wrong-symbols
• 152-rejoin-on-kick
• 2.0.13
• BiohZn/storage-dir
• add-blacklist-to-config
• add-ticker
• add-waffle.io-badge
• admin-config
• begin-testing-plugins
• botmode
• docker
• enum34-fix
• feature/async-plugin-close
• feature/config-management
• feature/last-fm-user-compare
• feature/movie-plugin
• feature/realname_and_ident_support
• fix-help-admins
• fix-openssl
• fix-persistent-blacklist
• fix-plugin-reload
• fix-predictions-again
• fix-ticker
• fix-ticker-again
• fix-weather-plugin
• fix-youtube-plugin
• global-quote-api
• improvements
• issue-144
• issue-45
• json-db
• json-db-ticker
• make-sed-a-default-plugin
• make-ticker-async
• make-urls-plugin-async
• master
• merge-old-release-3
• nullzion/event-decorator
• ordereddict-config
• pull/130
• pytest-env
• python-3
• real-name-and-ident-support
• release/2.2
• release/2.3
• release/3.0
• remove-accidental-commit
• restart-unless-stopped
• sed-exception
• sed-plugin
• seen-plugin
• sys-exit
• task/add-coveralls
• task/support-raw-messages
• ticker-fixes
• ticker-relay-bots
• twisted-update
• unicode-chars
• update-dependencies
• update-info-text
• update-readme
• update-twisted
• util-colors
• util-sleep
• v2.0.13
• v2.1.1
• v2.2.0
• v2.2.1
• v2.2.2
• v2.2.3
• v2.2.4
• v2.2.5
• v2.3.0
• v3.0.0
• wiki-utf8

Build # 270

Build Type

push

travis-ci-com

Committed by JohnMaguire

Commit Message

Fix symbol name in ticker reports

When writing Python code, I had assumed a for-loop created a new scoped
block, and that variables defined inside of it where only inside of it.
It turns out that is not true, so in an async world where you are using
a variable defined as part of the for-loop, the value is liable to
change out from under you.

A good hack is to define a default argument for the function you are
defining inside the loop with the same variable, as the function you
define has its own scope block.

Also fixed a couple instances of this bug in the core.

Run Details

687 of 749 relevant lines covered (91.72%)

0.92 hits per line