JoergAtGithub / mixxx

32%

main: 31%

LAST BUILD ON BRANCH portableAndSafeCharsetConversion

branch: portableAndSafeCharsetConversion

CHANGE BRANCH

x

Reset

Sync Branches

• portableAndSafeCharsetConversion
• AddFindFdkAac
• ClazyWarnings
• CompressorProxy
• ConvertEmptyFunctionToES2015Classes
• ENV__MIXXX_VCPKG_ROOT
• Enable_QML_macOS_x64
• FixClazy12errors_2.4
• FixClazy12errors_2.5
• FixClazy12errors_main
• FixTestCrashsWithEngineGetPlayer
• Fix_WiX_error_log
• Hercules-Control-MIX_ES6class
• HidInputPollOverloadWarning
• HidInputPullOverloadWarning
• No_Hardcoded_CI_ParallelLimit
• Optimize_BpmDelegate
• Optimize_WImageStore
• Optimize_WPixmapStore
• Optimize_basetrackcache
• Optimize_localDateTimeFromUtc
• PaintableDrawmodeEnumClass
• Qt6.8.3_Windows2022
• SlowEventLoopNotify
• TraceJavascriptConnection
• Traktor-Z2-2.3
• Traktor-Z2-HIDAPI_GetInput_HIDRAW
• UpdateHidApiDeclarations
• Update_WiX_toolset
• Use_makeCompressedConnection
• WideErrorDialogShowDetails
• Windows_warning_fixes
• Z1_new_ES6_Class
• abeltonlink
• abletonlink
• add_missing_Qt6_TLS_plugin
• beginTimerTest
• charsetConversionBomHandling
• clang-cl
• clazy_macos
• cleanupPixmapSource
• cmake_download_buildenv_zip
• cmake_download_buildenv_zip_macos
• con-pref-tab-layout-fixes
• configureCI
• controler_protocols
• controler_usage
• controllerApiDeclarations
• controllerSettingsLegacyAPI
• controller_device_info1
• controller_enumeration
• controller_pref_tab_layout
• controlobjectscripttest_cleanup
• copilot/fix-pascalcase-filenames
• dependabot_precommit
• disable_buildenv_cache
• djinterop_0.20.1
• enable_android_tests
• establishqualitywithpitch
• fixHidAddOutput
• fixSpinnyCoverArtLoadingFailures
• fix__m_psvg__mergeissue
• fix_android_build
• fix_android_build2
• fix_broken_pch_build
• fix_ci_on_cloned_repo_branches
• fix_controller_mapping_validation_test
• fix_exlint_hid_symbols
• fix_hid_parser_2.4
• fix_libraryFocusRTE
• fix_max_strlen_assert
• fix_msys2_bash_copy_workaround_for_arm64
• fix_opengles_precision_assert
• fix_pioneer_CDJ_init
• fix_playlistparser_warning
• fix_precommit_2.6
• fix_qt6_main_build
• fix_qt6_regression_in_VisualPlayPosition
• fix_s3_mapping_2.4
• fix_visual_loop_out_glitch
• fix_warning_wrong_type
• fix_windows_arm64_upload
• fix_windows_arm64_upload_openssh_agent
• fix_wix_dll_signing
• fix_wrong_type_warning
• frameSwap
• gitignore
• hercules_djcontrol_mix_rebased
• hid-parser-update
• hidSendDuplicateData
• hid_fifo_mode
• hid_fifo_mode2
• hid_fifo_mode3
• hid_io_thread
• hid_io_thread2
• hid_learning_wizard_gui
• hid_mapping_wizard
• hid_parser_perfomance_improvement
• hid_parser_perfomance_improvement_alternative
• hid_report_tabs
• hidapi_0.12.0
• hidoutputreportiteratorfix
• hidparser_fix_getActiveFieldGroup
• libdjinterop243vcpkg
• libraryRenderingInSync
• link_djinterop_public
• link_djinterop_public_2.4
• loadHidReportDescriptorAtEnumeration
• loadHidReportDescriptorAtEnumeration2
• localSyncRefSoundDeviceSelection
• macros-backend
• main
• mappinginfo1
• merge_from_main_to_2.4
• minorFixesForCommonHidPacketParser
• modernizeControllerManager
• nativeEventHandlerWindows
• noStyleUnpolish
• optimize_control_code
• optimize_enginecotrol_and_process
• painable3
• parametricGTestForMappings
• playindicator
• playposfix
• pr/13709
• pr/3623
• pr12370_winbuildenv_bat
• precommittest
• qbasewidgetimprovements
• qml_trigger
• qmlformat
• refs/heads/Windows_warning_fixes
• regressionFixCoverArtToolTip
• removeHidExamplesForKeyboardTrackpad
• removeQtModuleHeaderIncludes_2.5
• remove_egacy
• renameSetGetParameter
• renderTableWidgetsIntoPixmap
• replace_reset
• replace_wiki_by_manual
• revert_file_corrupted_by_precommit
• s2mk2_loaded_chain_preset
• safeCharsetList
• setProperPixmapCacheLimit
• setSwapInterval
• set_vistastyle
• stemcontrols2
• svgPixmap
• svgToPixmap
• tests_flatpack
• ubuntu_240401
• ubuntu_240401_module_include_check_enabled
• ubuntu_qt6
• unify_beatjumpandloopsize_rangecheck
• updateTo26buildenvAndSetVCtoolsetVersionForCi
• update_buildenv_2.5
• update_common-hid-packet-parser
• update_vcpkg_channel_change
• variousPerformanceImprovements
• vcpkg_27
• vcpkg_update_windows_fix
• warnings_fatal_qml_rendergraph
• windows_arm64
• windows_buildenv_cmakeToolchain_setting
• windows_buildenv_cmakecachefix

Build # 11994378685

Build Type

push

github

Committed by JoergAtGithub

Commit Message

Expanded WellKnownCharsets enum in engine-api.d.ts and
controllerscriptinterfacelegacy.h by all encodings that work with all supported Qt versions. I explicitly did not added three charsets, which triggered an infinite loop of the QJSEngine thread for me.
Made convertCharset function accepting string targetCharset private  for safety reasons.
Updated and added tests to ensure that we detect charsets that crash or result in unexpected output length.
Added a deep copy of the targetcharset name reference
Made encoder in Qt 6.4 case a self-deleting smart-pointer
Optimize QAnyStringView handling for Qt >=6.8.0
Improved error output
Unified behavior of the UCS2 charsets between platforms by adding Byte Order Mark if missing

Coverage Stats

224 of 227 new or added lines in 1 file covered. (98.68%)

164 existing lines in 1 file now uncovered.

33516 of 104502 relevant lines covered (32.07%)

48311.4 hits per line