Halibot / halibot

95%

master: 93%

LAST BUILD ON BRANCH allow-supplied-config

branch: allow-supplied-config

CHANGE BRANCH

x

Reset

• allow-supplied-config
• 0.1.0
• 0.2.0
• add-command-module
• add-malformed-message-exception
• another-test
• cli-config-command
• config-load-in-Config
• config-writer
• configurer
• contrib
• core-perm-module
• doc-types
• erichte/log-with-instance-name
• erichte/message-format-ri
• filter-ri-injection
• fix-eventloop-cleanup
• future
• help-dict
• help-doc
• help-text
• help-text2
• importable-packages
• install-ed-fix
• irc-completion
• local-system-configs
• log-traceback
• master
• more-tests
• origin-fix
• package-version
• perm-fixes
• perm-fixes-old
• repo-client
• repo-search
• sjrct-routes
• sjrct/fix-python-3.5
• sjrct/info-cmd
• split-instant
• split-sendto
• sync-send
• sync-send-deadlock-check
• test-cli

Build # 356

Build Type

Pull #113

travis-ci

Committed by web-flow

Commit Message

halibot: add optional config, configfile argument to core

With the eventual intent on moving some `main.py` functionality into modules,
it will be useful to reuse some of core's logic for temporary cli use. Thus,
we will need to spin up temporary instances of `Halibot` to load config, load
modules, etc.

This adds an optional keyword `config` to `Halibot`, which sets a config dict
as supplied. By default, this value is empty, as it was previously.

This also adds an optional keyword `configfile` to `Halibot`, to specify an
alternate configuration file to load on `._load_config()`. Therefore, this
method has also been updated to accept an optional parameter `configfile`
parameter of its own, in the event some external code wants to load an
alternate code without running the full start process.

The default config file remains `config.json`. In theory, no changes to
other code is necessary.

**NOTE:** With this change, `config` is no longer a static class variable,
and is now purely an instance variable. This probably shouldn't affect
anything, but multiple `Halibot` objects will no longer have the same
config dict object.

Pull Request Pull Request #113: halibot: add optional config, configfile argument to core

Run Details

10 of 10 new or added lines in 1 file covered. (100.0%)

917 of 970 relevant lines covered (94.54%)

1.89 hits per line