Fullscreen / yt

94%

master: 94%

LAST BUILD ON BRANCH v0.33.4

branch: v0.33.4

CHANGE BRANCH

x

Reset

• v0.33.4
• v0.4.7
• accept-env-variables
• v0.4.8
• master
• implement-access-token
• don-t-fail-on-adding-unavailable-videos
• v0.4.9
• remove-collection-resources
• only-update-passed-parameters
• v0.4.10
• fix-ruby-specs
• v0.5.3
• bug/playlist-status
• v0.5.4
• add-authentication
• temporarily-add-logger-to-notify-google-of-500-errors
• v0.5.5
• track-500-errors-separately
• v0.5.6
• analytics
• v0.5.7
• v0.5.8
• handle-random-400-error-from-youtube
• v0.5.9
• add-partnered-channels
• v0.5.10
• automatically-refresh-the-access-token
• v0.5.11
• rescue-503-errors
• v0.5.12
• retry-youtube-request-when-they-might-work-the-second-time
• v0.5.13
• v0.5.14
• v0.6.0
• fix-refresh
• v0.6.1
• extracting-status
• extracting-has-many
• extract-metrics
• feature/video-search
• add-filter-to-account-videos
• v0.6.2
• delegate-explicitly
• extract-reports
• retry-timeout
• v0.6.3
• bump-rspec
• better-code
• fix-annotations
• v0.6.4
• v0.6.5
• add-statistics
• fix-gzip-for-ruby-19
• v0.6.6
• v0.7.0
• extend-snippet
• v0.7.1
• add-video-update
• v0.7.2
• sort-videos-by-most-recent-first
• v0.7.3
• more-metrics
• v0.7.4
• metrics-for-non-content-owners
• v0.7.5
• reports-for-videos
• v0.7.6
• device
• better-weather
• activesupport-4.1.4
• upload-video
• v0.7.8
• add-todo
• channels-with-more-than-500-videos
• fix-travis-key
• fix-failing-spec
• v0.7.9
• upload-in-chunks
• add-viewer-percentages
• v0.7.10
• v0.7.11
• v0.8.0
• feature/claims
• add-status-fields
• v0.8.1
• feature/list-claims
• v0.8.2
• feature/content-owners-list
• v0.8.3
• feature/collection-include
• fix-annotations-with-0-timestamp
• v0.8.4
• feature/approval_prompt
• v0.8.5
• rename-rating-update-to-set
• v0.9.0
• accept-camelcase-privacy-status
• feature/references
• list-references
• v0.9.1
• update-video-status
• feature/policies
• v0.9.2
• feature/content-owner-detail
• fix-travis
• issue-43
• camelize
• update-accepts-both-underscore-and-camelcase
• feature/claim-third-party
• v0.9.3
• add-live-attributes
• add-live-streaming-detail
• transform-brackets-in-snippets
• fix-duration
• sanitize-angle-brackets
• temporarily-skip-content-owner-specs
• v0.9.4
• v0.9.6
• add-days-and-weeks-to-duration
• v0.9.7
• rename-time-updated
• size-not-count
• add-log-level
• v0.11.0
• yt-video-where
• test-rspec-tag
• v0.11.1
• bump-gems
• asset-monetization-flow
• asset-and-ownership
• update-tests
• add-yt-support-back
• add-new-url-back
• stage
• stage-2
• stage-3
• fix-claim-segments
• update-changelog-for-jcohenho
• v0.32.4
• yt-info
• update-patch-asset
• v0.32.5
• yt-collections-videos
• playlist-items-content-owner
• co-video-update
• be-kind-rewind
• co-upload-thumbnail
• v0.32.6
• vcr
• remove-by-week
• auth-no-api-key
• limit-refresh-retry
• version-bump
• v0.33.0
• channel-comment-count
• retry-refresh-token-once
• token-empty
• v0.33.2
• do-not-delete
• url-id-bug-fixes

Build # 591

Build Type

push

travis-ci

Committed by web-flow

Commit Message

Don't retry on quota errors (#401)

* Don't retry on quota errors

They say that insanity is doing the same thing over and over and
expecting different results...

This patch removes retry behavior on quota issues because:

* this isn't useful when daily quota has been reached
* in the case of 100s quota, you'd need to be attempting requests ~61s
into the quota cool-off in order for the final retry to succeed. That
seems pretty unlikely.

So for all practical purposes, when quota is reached, the library stalls
for the maximum timeout time (39s by my math). This is further
problematic when making requests in environments like Heroku that have
a 30s timeout for web request-response cycles.

Let's do the sane thing and just raise an error when quota is reached.

* Bump to 0.33.4 [ci-skip]

Run Details

5630 of 5994 relevant lines covered (93.93%)

40.58 hits per line