FAForever / server
95%
develop: 96%

LAST BUILD BRANCH: dependabot/pip/aiohttp-3.7.4
DEFAULT BRANCH: develop
Repo Added
Files 0
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH v1.3.5
branch: v1.3.5
CHANGE BRANCH
x

3357

push

travis-ci

web-flow 
Asyncio drain fix 2 (#532)

* Add `connected` field to QDataStreamProtocol to make cleanup easier

This makes it so that cleanup still happens only in one place in 
ServerContext, but other callers of `send_message` will also get an 
error if the protocol has disconnected. So for instance if the ladder 
service tries to send a message start a game but one client disconnects, 
`DisconnectedError` will be raised so that ladder service can 
approprately cancel the game setup, and the ServerContext will clean up 
the connection as soon as the disconnect is detected.

* Add a `broadcast` function for when we want to send normal json data

* Add send_mesage method to player

* Refactor GameConnection send method

* Add error handling to places where `send` was called other than from self

* Log sent messages after they've succesfully been sent.

* Use QDatastreamProtocol.close method

* Only call ladder_service on_connection_lost if player is not None

* Save connection before yielding

* Log suppressed exceptions at the debug level

* Set connected attribute when drain fails

* Suppress DisconnectedError as drain does not reliably raise exceptions

* await `_handle_lobby_state` properly

* Make sure `close` marks the protocol as disconnected

* Only broadcast to connected protocols

* Use transport is_closing property directly

* Clean up some exception logging

* Don't yield between checking weak reference existence

* Explicitly check host player state instead of asserting as precondition

* Handle GameError explicitly

* Ignore DisconnectedError when we know the host has already timed out

* More weak reference checking

* Adjusting tests for travis

* Refactor tests

* Remove dead code

* Add more tests for QDatastreamProtocol

* Ignore peer disconnects when joining a game

* Ignore disconnects when trying to kick someone

* Add some fast forwards to speed up tests

* Move tests to their... (continued)

3172 of 3344 relevant lines covered (94.86%)

0.95 hits per line

Relevant lines Covered
3344 RELEVANT LINES 3172 COVERED LINES
0.95 HITS PER LINE
Source Files on v1.3.5
Detailed source file information is not available for this build.

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
3357 v1.3.5 Asyncio drain fix 2 (#532) * Add `connected` field to QDataStreamProtocol to make cleanup easier This makes it so that cleanup still happens only in one place in ServerContext, but other callers of `send_message` will also get an error if ... push web-flow travis-ci pending completion  
See All Builds (3416)