Eyevinn / hls-m3u8
92%
main: 92%

LAST BUILD BRANCH: accept-trailing-scte35-daterange
DEFAULT BRANCH: main
Repo Added
Files 5
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH fix/encode-ring-wraparound
branch: fix/encode-ring-wraparound
CHANGE BRANCH
x

coverage: 92.466% (+0.2%) from 92.301%
30286050163

Pull #91

github

tobbee 
fix: remove expired partial segments when a full segment is appended

removeExpiredPartials was only called from AppendPartialSegment, so the
retention rule was only applied when a new partial segment arrived. A
producer that stops adding partial segments, for example at the end of a
stream or when switching away from low latency, kept them forever, and
IsSegmentReady kept reporting them as available long after they had left
the playlist. Encode filtered them out of the output, so this was stale
in-memory state rather than a bad playlist.

Call it from AppendSegment as well, since a new full segment also moves
the end of the playlist forward. Remove is not affected, as it moves the
head and leaves the end of the playlist where it was, and Slide appends.

Also state the retention rule once, as a named constant referring to the
three target durations of the specification, and filter in place instead
of rebuilding the slice on every call. The previous comment claimed to
keep all partial segments when there are fewer than 3 full segments, but
the value tested is a sequence number, not a count. It only guards
against underflow, which the new code says explicitly.
Pull Request #91: fix: three Encode() bugs — ring buffer wraparound panic, wrong EXT-X-MEDIA-SEQUENCE, consumed partial segments

55 of 56 new or added lines in 1 file covered. (98.21%)

2246 of 2429 relevant lines covered (92.47%)

1.08 hits per line

Relevant lines Covered
2429 RELEVANT LINES 2246 COVERED LINES
1.08 HITS PER LINE
Source Files on fix/encode-ring-wraparound

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
30286050163 fix/encode-ring-wraparound fix: remove expired partial segments when a full segment is appended removeExpiredPartials was only called from AppendPartialSegment, so the retention rule was only applied when a new partial segment arrived. A producer that stops adding partial ... Pull #91 tobbee github
92.47
30285641912 fix/encode-ring-wraparound docs: update CHANGELOG.md for the partial segment fix Pull #91 tobbee github
92.39
30283961846 fix/encode-ring-wraparound docs: update CHANGELOG.md for PR #90 and PR #91 Pull #91 tobbee github
92.28
30283931663 fix/encode-ring-wraparound docs: add Khoi Van Nguyen to AUTHORS for PR #90 Pull #91 tobbee github
92.28
See All Builds (168)