DrudgeCAS / gristmill

91%

master: 92%

LAST BUILD ON BRANCH deps/bump-cpp-submodules

branch: deps/bump-cpp-submodules

CHANGE BRANCH

x

Reset

Sync Branches

• deps/bump-cpp-submodules
• ci/release-0.9.0
• ci/release-please
• ci/release-please-setup
• ci/ruff
• copilot/add-cprinter-unit-tests
• copilot/sub-pr-16
• copilot/sub-pr-9
• copilot/update-git-submodules
• copilot/update-git-submodules-again
• dependabot/github_actions/actions/checkout-6
• dependabot/github_actions/actions/setup-python-6
• dependabot/github_actions/astral-sh/setup-uv-7
• dependabot/submodules/deps/fbitset-3a54534
• dependabot/submodules/deps/fbitset-bf87654
• dependabot/submodules/deps/libparenth-b1e240e
• dependabot/uv/dependencies-1ab08fcbb0
• dependabot/uv/dependencies-1d49c30b6a
• dependabot/uv/dependencies-890d39c709
• dependabot/uv/dependencies-b6b76a6067
• dependabot/uv/filelock-3.20.3
• dependabot/uv/idna-3.15
• dependabot/uv/pygments-2.20.0
• dependabot/uv/pytest-9.0.3
• dependabot/uv/requests-2.33.0
• dependabot/uv/tornado-6.5.7
• dependabot/uv/urllib3-2.7.0
• deps/refresh-drudge-lock
• fix/deterministic-dimension-chunks
• fix/deterministic-optimization
• fix/index-free-product-crash
• fix/order-independent-constriction
• fix/scikit-build-core-config-keys
• fix/verify-external-symbols
• master
• scikit
• test/restore-ccsd-energy-assertion
• tmp/check-effective-t-on-linux

Build # 31895519980

Build Type

Pull #36

github

Committed by chenpeizhi

Commit Message

deps: Bump fbitset and libparenth, and cover the crash they fixed

libparenth applied its unnatural-partition skip to every problem, though
it is only valid for classical contractions where each summation is
involved by exactly two factors.  Outside that it could skip every
candidate, leaving a subproblem with no evaluation, and then read the
first element of an empty vector.  From Python that is a segfault of the
interpreter, with no exception and no traceback.

    targets = [dr.define_einst(s, x[a] * y[a] * z[a] * w[a])]
    optimize(targets, contr_strat=ContrStrat.OPT)      # segmentation fault
    optimize(targets, contr_strat=ContrStrat.GREEDY)   # segmentation fault

fbitset also had the iterator read one limb past the end of its storage,
on every complete walk over a bit set, and could not be included from two
translation units.

Add a test for the four-factor summation, since the crash was only ever
reachable from Python and nothing here would have caught it coming back.
On the previous submodules it takes the whole pytest process down; on
these it passes, with every strategy agreeing on the cost.  It is stable
across hash seeds.

Test suite: 31 passed, 2 xfailed.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Pull Request Pull Request #36: deps: Bump fbitset and libparenth, and cover the crash they fixed

Coverage Stats

1783 of 1954 relevant lines covered (91.25%)

0.91 hits per line