Displayr / flipStandardCharts

59%

master: 87%

LAST BUILD ON BRANCH fix-tests

branch: fix-tests

CHANGE BRANCH

x

Reset

• fix-tests
• DS-2583
• DS-2592
• DS-2637
• DS-2721
• DS-2722
• DS-2724
• DS-2725
• DS-2728
• DS-2744
• DS-2790
• DS-2808
• DS-2823
• DS-2843
• DS-2843-2
• DS-2870
• DS-2894
• DS-2938
• DS-2969
• DS-3083
• DS-3084
• DS-3085
• DS-3136
• DS-3140
• DS-3167
• DS-3168
• DS-3202
• DS-3236
• DS-3244
• DS-3268
• DS-3563
• DS-3597
• DS-3647
• DS-3886
• DS-3886-2
• DS-4143
• FR-167
• FS-11975
• RS-10882
• RS-11414
• RS-12285
• RS-13816
• RS-13816-2
• RS-13816-3
• RS-7135-areachart-guineapig
• RS-7135-iframeless-activate
• VIS-1002-scatterlabels
• VIS-1049
• VIS-1049-2
• VIS-1087
• VIS-1087-2
• VIS-1090
• VIS-1096
• VIS-350
• VIS-535
• VIS-606
• VIS-610
• VIS-636
• VIS-642
• VIS-642-2
• VIS-912-2
• VIS-930
• VIS-930-2
• VIS-930-3
• VIS-945
• VIS-974
• VIS-975
• VIS-980
• VIS-994
• VIS-999
• VIS_982
• bugdup20529
• defaultcolors
• fix-axisbounds
• fix-plotlyupdate-restorepadding
• fix-radar-axisconstraints
• fix-tickposition
• iframeless-sparkline-test
• iframeless-take-two
• master
• mwm-ds2521
• nat-examples
• tg-hovertextNA
• untracked_fix_grep_when_subscripting
• zendesk76300

Build # 767

Build Type

push

travis-ci

Committed by mwmclean

Commit Message

Fix handling of NSE with charts wrapping Distribution

* The use of match.call() in several charting functions (bean,
histogram, density, violin, box) could create issues with scoping
and non-standard evaluation.  This commit fixes this issue by
forcing evaluation of those problematic variables in the parent
frame before executing the call to Distribution with do.call().

* The previous code would fail when used with testthat, as
variables created in the test script would be out of scope
when do.call was used inside the mentioned charting functions

Addresses: DS-1617

Run Details

3110 of 5231 relevant lines covered (59.45%)

66.99 hits per line