DiamondLightSource / ispyb-api

82%

master: 83%

LAST BUILD ON BRANCH move-exceptions

branch: move-exceptions

CHANGE BRANCH

x

Reset

• move-exceptions
• MXSW-1173
• MariaDB-10.2
• SCI-6176
• SCI-7414
• SCI-7445
• SCI-7452-plus
• SCI-7805
• SCI-7986
• SCI-8045
• SCI-8592
• appa_exp_sessions
• auth_login
• badges
• black
• bugfixes
• bulk-pia
• bumpversion
• changelog
• cleanup
• container
• dcg_retrieve_upsert
• deprecations
• detector_model
• dimplefix
• docs
• download_ispyb_db
• drop-legacy
• exceptions
• fix-dictionary-cursor-queries
• future-autocommit
• future-disconnect
• get-dcid-info
• gh-code-scanning
• implicit-factory
• incl_scripts
• insert_phasing_analysis_results
• insert_subsample
• integrityerror
• iqi_change
• legacy
• legacy-work
• lgtm
• master
• misc_features
• model
• model-updates
• motion_corection_drift
• mysql-connector-python
• objectmodel
• open
• open_ctx_mngr
• pdb
• precommit
• precommit-update
• processingjob
• py37
• python3
• readme_pip_fix
• reconn_params
• reconnect
• reduce-legacy-bits
• retire-ingester
• retrieve_container_for_sample_id
• retrieve_persons_for_session
• retrieve_persons_for_session_2
• retrieve_prog_attach_importance_rank
• retrive_dc
• rm_upsert_program
• roles
• sample_group
• sample_image_auto_score
• sample_model
• samples_not_loaded
• schema
• skiptests
• testdb
• travis
• travis-ci-com
• unassign_all
• updated_readme
• upsert_program_ex
• upsert_tests
• use_open
• v1.0.3
• v2.0.0
• v3.0.0
• v3.0.1
• v3.1.0
• v3.2.0
• v3.3.0
• v4.0.0
• v4.1.0
• v4.10.0
• v4.11.0
• v4.11.1
• v4.12.0
• v4.13.0
• v4.13.1
• v4.13.2
• v4.3.0
• v4.4.0
• v4.5.0
• v4.6.0
• v4.7.0
• v4.7.1
• v4.8.0
• v4.9.0
• v5.0.0
• v5.1.0
• v5.2.0
• v5.2.1
• v5.3.0
• v5.4.0
• v5.4.1
• v5.5.0
• v5.6.0
• v5.6.1
• v5.6.2
• v5.7.0
• v5.7.1
• v5.8.0
• v5.8.1
• v5.9.0
• version-4.13.2
• version-4.5.0
• version4.6.0
• xtalimaging

Build # 469

Build Type

Pull #64

travis-ci

Committed by web-flow

Commit Message

Move ispyb.exceptions to ispyb

and remove 'ISPyB' and 'Exception' from class names.

Currently we use the exceptions as in:
    try:
        (..)
    except ispyb.exception.ISPyBNoResultException:
        (..)
which is overly verbose:
* It contains the word 'ispyb' twice
* It contains the word 'exception' twice,
* which is completely pointless because anything in
  'except (..):' and 'raise (..)' must be an exception anyway.

Therefore move all exceptions from ispyb.exceptions into the ispyb main
class, giving them shorter names. ISPyBKeyProblem is replaced by the
python builtin KeyError. ispyb.exception remains available to import
until the next major release but will generate a deprecation warning on
import.

Pull Request Pull Request #64: Move ispyb.exceptions to ispyb

Run Details

37 of 37 new or added lines in 6 files covered. (100.0%)

1041 of 1264 relevant lines covered (82.36%)

4.1 hits per line