DemocracyClub / WhoCanIVoteFor

60%

master: 58%

LAST BUILD ON BRANCH hotfix/optional-fields

branch: hotfix/optional-fields

CHANGE BRANCH

x

Reset

• hotfix/optional-fields
• master
• linky-slacky
• hustings-time
• tfgg-patch-1
• wikipedia-once
• less-insertion
• add-candidate-cvs
• update-readme
• embed-candidate-tweets
• corporate-overlords
• add-candidate-intros-and-meta-descriptions
• add-leaflets
• add-party-manifestos
• donateion_on_feedback
• import-nesta-educational-data
• link-to-where-for-ambiguous-postcodes
• results
• elections_on_home_page
• fix_donation_form
• ynr_cta
• 2018-locals-updates
• non-division-elections
• circleci
• JoeMitchell-copyedits
• issue269
• dependabot/pip/vcrpy-2.0.0
• dependabot/pip/vcrpy-2.0.1
• dependabot/pip/pillow-5.3.0
• remove-mentions
• dependabot/pip/gocardless-pro-1.9.0
• dependabot/pip/psycopg2-binary-2.7.6.1
• dependabot/pip/six-1.12.0
• dependabot/pip/hiredis-1.0.0
• dependabot/pip/psycopg2-binary-2.7.7
• dependabot/pip/redis-3.1.0
• dependabot/pip/redis-3.2.0
• dependabot/pip/redis-3.2.1
• 340-lock-status-in-api
• 339-party-emblem-size
• link-cards
• emblem_url
• city-mayors
• sentry
• JoeMitchell-patch-1
• dependabot/pip/psycopg2-binary-2.8
• dependabot/pip/psycopg2-binary-2.8.1
• dependabot/pip/sentry-sdk-0.7.10
• fix-donate-js
• dependabot/pip/sentry-sdk-0.11.0
• dependabot/pip/redis-3.3.8
• dependabot/pip/sentry-sdk-0.11.1
• dependabot/pip/stripe-2.35.1
• dependabot/pip/sentry-sdk-0.11.2
• dependabot/pip/djangorestframework-3.10.3
• dependabot/pip/stripe-2.36.0
• dependabot/pip/stripe-2.36.1
• dependabot/pip/sentry-sdk-0.12.2
• stop-deadlocks
• dependabot/pip/pillow-6.2.1
• dependabot/pip/sentry-sdk-0.13.1
• add-more-fields
• dependabot/pip/django-2.2.7
• dependabot/pip/psycopg2-binary-2.8.4
• dependabot/pip/stripe-2.38.0
• dependabot/pip/django-debug-toolbar-2.0
• dependabot/pip/six-1.13.0
• dependabot/pip/stripe-2.39.0
• dependabot/pip/sopn-publish-date-1.3.2
• dependabot/pip/stripe-2.40.0
• dependabot/pip/gunicorn-20.0.0
• standing-link
• dependabot/pip/stripe-2.43.0
• dependabot/pip/gocardless-pro-1.16.0
• coronavirus-updates
• dependabot/pip/stripe-2.44.0
• dependabot/pip/pillow-7.1.1
• dependabot/pip/psycopg2-binary-2.8.5
• dependabot/pip/gocardless-pro-1.16.1
• dependabot/pip/stripe-2.45.0
• dependabot/pip/pillow-7.1.2
• dependabot/pip/stripe-2.47.0
• dependabot/pip/stripe-2.48.0
• dependabot/pip/six-1.15.0
• dependabot/pip/gocardless-pro-1.19.0
• dependabot/pip/django-2.2.13
• dependabot/pip/pillow-7.2.0
• dependabot/pip/gocardless-pro-1.20.0
• dependabot/pip/stripe-2.49.0
• dependabot/pip/stripe-2.50.0
• dependabot/pip/gocardless-pro-1.21.0
• dependabot/pip/psycopg2-binary-2.8.6
• dependabot/pip/django-debug-toolbar-3.0
• dependabot/pip/django-debug-toolbar-3.1
• dependabot/pip/requirements/django-2.2.13
• dependabot/pip/stripe-2.53.0
• dependabot/pip/stripe-2.54.0
• dependabot/add-v2-config-file
• dependabot/pip/vcrpy-4.1.1
• dependabot/pip/stripe-2.55.0
• dependabot/pip/sentry-sdk-0.19.2
• dependabot/pip/django-redis-4.12.1
• dependabot/pip/pillow-8.0.1
• dependabot/pip/djangorestframework-3.12.2
• dependabot/pip/sentry-sdk-0.19.3
• dependabot/pip/django-model-utils-4.1.0
• dependabot/pip/django-model-utils-4.1.1
• dependabot/pip/stripe-2.55.1
• dependabot/pip/pillow-8.1.0
• assign-correct-posts
• An-attempt-to-explain
• Happy-New-Year!
• macos-installation
• hotfix/future-elections
• markdown-to-html
• hotfix/delete-deleted-elections
• hotfix/delete-unused-deps
• hotfix/remove-results-app
• hotfix/remove-posts-fields
• feature/division-types
• pmk01-patch-1
• hotfix/orphan-posts-cleanup
• hotfix/limit-person-bio
• hotfix/django-dependabot
• hotfix/polls-open-postcode-view
• rebase-test
• dependabot/pip/django-extensions-3.1.1
• bugfix/redis
• hotfix/pcc-label
• bugfix/blank-ynr-id
• dependabot/pip/sentry-sdk-0.20.0
• election-page-enhancements
• feature/election-enhancements
• hotfix/ballot-meta-description
• feature/person-detail-twfy-id
• bugfix/update-candidacies
• bugfix/dependabot
• ec2_tags
• feature/local-parties-2021
• pmk01-patch-2
• feature/referendums
• dependabot/pip/pillow-8.1.2
• frontend-snags
• feature/hustings-2021
• breadcrumbs
• bump-design-system
• feature/import-parish-councils
• hotfix/parishes-hustings
• feature/local-parties-update
• design-system-changes
• hotfix/hustings-ordering
• dependabot/pip/hiredis-2.0.0
• hotfix/importers
• hotfix/manifestos
• dependabot/pip/pillow-8.2.0
• bugfix/parties-importer
• dependabot/pip/requirements/django-2.2.20
• bugfix/hustings-url-length
• hotfix/hustings-import
• hotfix/sopn-links
• hotfix/person-intro
• bugfix/remove-cvs
• bugfix/duplicate-post-elections
• dependabot/pip/black-21.4b0
• bugfix/manifesto-language
• bugfix/manifesto-lang-cleanup
• election-booklets-2021
• hotfix/parishes-card
• smaller-candidates-cards
• leaflets
• bugfix/local-party-card
• hotfix/import-elected
• dependabot/pip/django-localflavor-3.1
• dependabot/pip/django-redis-5.0.0
• feature/party-name
• bugfix/voting-system
• bugfix/party-name-migration
• dependabot/pip/pillow-8.3.0
• hotfix/remove-scope
• small-ds-cleanups
• hotfix/favicon
• dependabot/pip/requests-2.26.0
• feature/front-end-testing
• feature/aws-lambda
• hotfix/font-size
• hotfix/results-table
• hotfix/bump-ds
• staging
• feature/croydon-referendum
• hotfix/utils-version
• hotfix/referendums
• hotfix/remove-travis
• dependabot/pip/aws-sam-cli-1.32.0
• michael-test
• bugfix/django-version
• dependabot/pip/awscli-1.20.50
• feature/import-recent-ballots
• hotfix/emojis
• dependabot/pip/pillow-8.4.0
• pmk01-patch-3
• feature/import-people
• dependabot/pip/awscli-1.21.7
• hotfix/last-updated-timestamps-endpoint
• hotfix/results-importers
• move-to-alb
• add-api-rule
• update-import-parties
• hotfix/sitemaps
• enable-dev-deploys
• feature/voting-feedback
• hotfix/uncontested-text
• add-slack-feedback-event
• hotfix/image-preview
• development
• dependabot/pip/redis-4.0.2
• dependabot/pip/awscli-1.22.18
• dependabot/pip/awscli-1.22.19
• hotfix/dependabot-PRs
• dependabot/pip/awscli-1.22.27
• importer-debuging
• dependabot/pip/awscli-1.22.28
• dependabot/pip/awscli-1.22.29
• bugfix/any-non-by-elections
• dependabot/pip/awscli-1.22.43
• hotfix/add-blog
• bugfix/candidates
• referendum-text
• hustings-2022
• logger-db
• dependabot/pip/redis-4.1.3
• update-deps
• dependabot/pip/requirements/pillow-9.0.0
• local-parties-2022
• bugfix/mailing-list-backend
• fix-hustings-on-person-page
• welsh-translations
• translate-ballot-pages
• dummy-profiles
• dependabot/pip/awscli-1.22.74
• dependabot/pip/awscli-1.22.75
• bugfix/hustings
• feature/previous-party-affiliations
• api-leaflets-and-hustsings
• exclude-candidacies-from-import-ballots
• dependabot/pip/aws-sam-cli-1.41.0
• dependabot/pip/awscli-1.22.78
• transifex
• welsh-translations-continued
• lambda-event-tweaks
• feature/previous-party-affiliation
• feature/previous-party-affiliations-michael
• bugfix/party-emblem
• previous-party-template
• hotfix/emblem-size
• bugfix/candidate-ordering
• feature/volunteer-CTA
• hotfix/sopn-publish-date
• hotfix/center-copytright
• bugfix/translations
• local-parties
• typo/-person-about-card
• en-translations
• voter-registration-deadline
• api-key-fallback
• hotfix/remove-status
• feature/whole-page-translations
• hotfix/party-detail
• local-parties-dont-order-rows
• hotfix/translation-bug
• enable-election-leaflets
• translations_locale-en-lc-messages-django-po--transifex_cy
• translations_locale-en-lc-messages-django-po--master_cy
• fix-leaflet-display
• wikipedia
• compile-messages
• dc-logging-client
• advance-voting-translations
• bugfix/import-manifestos
• bugfix/local-parties
• bugfix/compilemessages
• compile-messages-tox
• requests-timeouts
• requirements-changes
• tower-hamlets-mayor-booklet
• increase-prod-instances
• gevent
• update-ami-gevent
• bugfix/cancelled-election-title
• hotfix/translate-how-to-vote
• bugfix/logger-migrate
• hide-all-upcoming-elections
• bugfix/stv-explainer
• stv-seats
• last-updated-ts
• dependabot/pip/sentry-sdk-1.5.11
• hotfix/uncontested-translation
• increase-instances
• hotfix/ballot-typo
• post-election-changes
• show-by-elections
• feature/flourish-results
• hotfix/export-sources
• feedback-csv-new-fields
• rds-settings-changes
• test-increase-instances
• reduce-prod-instances
• bugfix/sites-table-replication
• remove-results-2022
• bugfix/winner-count
• docs/code-deploy
• hotfix/missing-translations
• dependabot/pip/redis-4.3.2
• hotfix/stv-translation
• pmk01-patch-4
• hotfix/count-not-available
• dependabot/pip/django-debug-toolbar-3.5.0
• hotfix/welsh-stv-text
• dependabot/pip/requirements/django-3.2.15
• hotfix/update-election-timetables
• m1_readme_updates
• hotfix/cal-url
• hotfix/uk-election-timetables-2.3.0
• hotfix/dependabot-update
• pmk01-patch-5
• feature/goat-counter
• add-scss
• uncontested-fixes
• hotfix/CI-and-upgrades
• hotfix/uncontested-metadata
• hotfix/uncontested-template-fix
• hotfix/fix-metadata-migration
• hotfix/dummy-postcode-view
• hotfix/aws-instances
• hotfix/dependency-upgrades
• hotfix/payload-fix
• num_ballots_fix
• hotfix/ignore-patch-updates
• hotfix/purge-no-id-messaging
• use-ee-base-ami
• sync_elections_cron
• bump-uk-election-timetables-2.4.0
• hotfix/notifications
• hotfix/dc-utils-not-found
• hotfix/og-image-preview
• hotfix/www-redirect
• local-parties-2023
• hustings-2023
• update-ee-ami
• load-testing-1
• feature/photo_id_wording
• hotfix/bad-template-tag
• hotfix/remove-staging-from-ci
• hotfix/broken-independent-card
• hotfix/slack-feedback-frequency
• hotfix/reinstate-staging-code-deploy
• feature/order-by-votes
• new-ee-base-image-subdivide
• hotfix/slack-cron-job
• longer-lambda-time
• feat/party-model
• feat/party-emblems-descriptions
• hotfix/metadata-display
• feat/party-pages-initial
• remove-home-page-ballots
• feat/party-pages-emblems
• really-remove-upcoming-elections
• feat/postal-votes-ni
• feat/party-page-emblems
• feat/party-pages-non-party
• hotfix/people-list-cancelled-election
• show-candidates-smarter
• hotfix/feedback-form-colours
• hotfix/results-banner
• hotfix/remove-facebook-mentions
• hotfix/homepage-id-messaging
• hotfix/turn-off-id-messaging
• hotfix/turn-off-results
• hotfix/minor-text-changes
• hotfix/remove-results-banner
• hotfix/fix-mailing-list
• hotfix/dont-crowdsource-after-sopn-day
• fix-ical
• re-enable-cron-jobs
• hotfix/signup-url
• hotfix/error-message-handling
• hotfix/postgres-error
• hotfix/division-suffix-error
• hotfix/display-by-elections
• hotfix/post-slack-feedback-weekly
• hotfix/revert-home-page-elections
• hotfix/schedule-weekly-slack-feedback
• feature/party-pages-update
• attempt-rds-deploy-fix
• hotfix/sendgrid-config
• cloudwatch-to-initial-setup
• hotfix/social-media-updates
• bump-timeout
• application-stop
• hotfix/elections-on-home-page
• feature/party_nations
• feature/ruff
• bump-uk-election-timetables-2.4.1
• fix-cache
• hotfix/no-upcoming-elections
• delete-odd-file
• dependabot/pip/ruff-0.0.284
• hotfix/ynmp-parties
• hotfix/add-candidate-links-to-election-table
• hotfix/wikipedia-job
• hotfix/reformat-cron-job
• feature/add-turnout-and-spoilt-ballots
• feature/cancellation-reason
• hotfix/link-to-wikipedia-bios
• hotfix/no-election-text
• hotfix/pre-sopn-ballot-text
• event-bridge-signup-form
• hotfix/preview-link-ballot-page
• circleci-editor/312/master
• name-mayoral-elections
• fix-election-filters
• hotfix/django-vulnerability
• dont-retry
• hotfix/add-ynr-api-key
• hotfix/ynr-key-import-people
• hotfix/electorate-comma
• hotfix/show-explanations-booklets
• hotfix/booklet-layout
• hotfix/if-uncontested-mark-elected
• ppc-fixes
• ppc-banner
• design-system-0.4.1
• hotfix/special-chars
• hotfix/design-system-0.4.2
• pmk01-patch-6
• hotfix/reformat-explainers
• hotfix/design-system-0.0.4
• hotfix/translation-correction
• hotfix/deselected-formatting
• fix-ppc-metadata
• remove-duplicate-sentry
• feature/last-updated-bio-timestamp
• hotfix/deselected-person-detail
• pmk01-patch-8
• hotfix/add-lewisham-booklet
• fix-email-display
• 2024-sheets-imports
• hotfix/independent-cards
• hotfix/last-updated-statement
• hotfix/sort-by-elected
• hotfix/last-updated-voter-statement-import
• hotfix/wikipedia-duplicate
• hotfix/fix-feedback
• hotfix/remove-postal-vote
• hotfix/cta-for-contact-info
• hotfix/explainers-not-updating
• pmk01-patch-9
• pmk01-patch-10
• hotfix/pre-sopn-day-text
• booklet-mayor-of-london-2024
• hotfix/misc-tidy
• open-details-on-hash-change
• hotfix/yorkshire-booklets
• hotfix/make-details-consistent
• hotfix/booklets-for-liverpool
• hotfix/last-modified-date
• hotfix/booklets-for-manchester-sheffield
• hotfix/booklet-mayor.salford.2024-05-02
• hotfix/booklets-for-midlands
• additional-uk-election-ids-data
• hotfix/load-translations
• hotfix/change-trans-tags
• hotfix/party-filter-but
• hotfix/party-filter-bug
• hotfix/misc-upgrades
• feature/timetable-logic
• hotfix/postal-vote-changes
• hotfix/gunicorn
• fix-manifesto-link
• hotfix/remove-en-from-cy-file
• hotfix/slack-notifications
• reduce-instance-count
• hotfix/export-feedback-button
• hotfix/replace-ppcs-banner
• hotfix/always-show-council
• dependabot/pip/ruff-0.4.4
• hotfix/joint-party
• hotfix/dont-show-voter-info
• hotfix/remove-banner
• hotfix/GE-sopn-date
• dependabot/pip/boto3-1.34.112
• hotfix/2024-manifesto-importer
• hotfix/2024-ge-hustings
• hotfix/stop-importing-local-parties
• hotfix/only-import-ge-hustings
• hotfix/ge-home-page-message
• hotfix/2024-ge-parties-import
• hotfix/speaker-page
• hotfix/biography-in-markdown
• hotfix/feedback-more-less-likely-fix
• hotfix/handle-key-error-people-import
• pmk01-patch-11
• person-redirects
• verb-logic-for-crrent-elections
• hotfix/fix-party-link-for-speaker
• pmk01-patch-12
• hotfix/show-national-party
• parl-boundary-change-card
• hotfix/national-party-manifesto
• better-ni-voter-id-link
• hotfix/city-of-london
• hotfix/national-manifestos
• hotfix/remove-by-elections-from-home
• hotfix/feedback-form-for-mobile
• hotfix/run-national-party-importer-more
• match-on-party-object
• hotfix/add-menu-to-single-ballot
• dependabot/pip/boto3-1.34.128
• fix-leaflet-import
• hustings-warning
• hotfix/linkedin-username-fix
• nicer-maps
• hotfix/dont-show-manifesto
• hotfix/update-welsh-for-hustings
• hotfix/add-regional-con-unionist-manifesto
• hotfix/move-booklets-to-s3
• hotfix/regional-manifestos-fixup
• hotfix/add-regional-manifestos
• hotfix/fix-regional-manifestos-2
• dependabot/pip/boto3-1.34.132
• hotfix/load-translation-tag
• hotfix/help-text
• hotfix/handle-suffix-error
• parl-24-results
• hotfix/revert-col-edge-case
• dependabot/pip/boto3-1.34.142
• cambridge-mayor
• dependabot/pip/ruff-0.5.4
• basic-auth-on-dev-and-stage
• dependabot/pip/boto3-1.34.157
• local-example
• upgrades202408
• moar-checks202408
• testdev20240821
• temp20240821
• hotfix/decrease-feedback
• bump-django-4.2.16
• dependabot/pip/boto3-1.35.37
• invalid-html20241025
• resp20241025
• col20241028
• contact-details20241028
• uk-election-pkgs20241112
• detect-migrate-fail
• sentry-disallowed-host
• aws-cli-orb

Build # 770fe4ac-f457-4a9c-b4fe-b969499e7118

Build Type

Pull #1977

circleci

Committed by VirginiaDooley

Commit Message

Handle absence of some fields in objects

When running python manage.py import_ballots for the first time on a fresh DB, I ran into exceptions because these fields weren't present for some of the fetched data.

This now treats these fields as optional, and falls back to reasonable default behaviours if they're absent.

This can be tested by following the database setup steps of the README without this change, observing errors, then trying again with these patches and observing success.

Pull Request Pull Request #1977: Handle absence of some fields in objects

Run Details

1 of 2 new or added lines in 2 files covered. (50.0%)

2733 of 4546 relevant lines covered (60.12%)

0.6 hits per line