CyclopsMC / EvilCraft

35%

master-26: 37%

LAST BUILD ON BRANCH copilot/fix-chalice-crash-issue

branch: copilot/fix-chalice-crash-issue

CHANGE BRANCH

x

Reset

Sync Branches

• copilot/fix-chalice-crash-issue
• 1.21.1-1.2.62
• 1.21.1-1.2.63
• 1.21.1-1.2.64
• 1.21.1-1.2.65
• 1.21.1-1.2.66
• 1.21.1-1.2.67
• 1.21.1-1.2.68
• 1.21.1-1.2.69
• 1.21.1-1.2.70
• 1.21.1-1.2.71
• 1.21.1-1.2.72
• 1.21.1-1.2.73
• 1.21.1-1.2.74
• 1.21.1-1.2.75
• 1.21.1-1.2.76
• 1.21.1-1.2.77
• 1.21.1-1.2.78
• 1.21.1-1.2.79
• 1.21.1-1.2.80
• 1.21.1-1.2.81
• 1.21.1-1.2.82
• 1.21.1-1.2.83
• 1.21.1-1.2.84
• 1.21.1-1.2.85
• 1.21.1-1.2.86
• 1.21.1-1.2.87
• 1.21.1-1.2.88
• 1.21.1-1.2.89
• 26.1.1-1.2.84
• 26.1.1-1.2.85
• 26.1.1-1.2.86
• 26.1.1-1.2.87
• 26.1.1-1.2.88
• 26.1.1-1.2.89
• 26.1.2-1.2.89
• 26.1.2-1.2.90
• 26.1.2-1.2.91
• 26.1.2-1.2.92
• 26.1.2-1.2.93
• 26.1.2-1.2.94
• 26.1.2-1.2.95
• 26.1.2-1.2.96
• 26.1.2-1.2.97
• 26.1.2-1.2.98
• 26.1.2-1.2.99
• copilot/add-config-option-broom-disable
• copilot/add-disable-auto-output-config
• copilot/add-enchantment-id-blacklist
• copilot/add-game-test-origins-of-darkness
• copilot/add-game-tests-for-advancements
• copilot/add-negative-game-tests-advancements
• copilot/add-undead-leaves-particle-color
• copilot/analyze-code-coverage-game-tests
• copilot/fix-automatic-blood-filler-crash
• copilot/fix-box-of-eternal-closure-crash
• copilot/fix-concurrent-modification-exception
• copilot/fix-concurrent-modification-exception-again
• copilot/fix-crash-on-startup
• copilot/fix-dark-tank-issue
• copilot/fix-duplication-bug
• copilot/fix-environmental-crash
• copilot/fix-game-test-failure
• copilot/fix-game-test-null-pointer
• copilot/fix-illegal-state-exception-biome
• copilot/fix-lootfunctioncopytankdata-crash
• copilot/fix-minecraft-crash
• copilot/fix-npe-in-hover-text
• copilot/fix-unwanted-mobs-spirit-furnace
• copilot/fix-weather-accumulation-crash
• copilot/investigate-game-test-failure
• feature/1-21-8
• imgbot
• l10n_crowdin_translations
• master-1.21
• master-1.21-lts
• master-1.21.10
• master-1.21.4
• master-1.21.8
• master-26
• master-26-lts
• patch-1
• patch-2

Build # 22777597426

Build Type

Pull #1168

github

Committed by Copilot

Commit Message

Fix crash when breaking entangled chalice full of blood

- Fix RenderItemStackBlockEntityEntangledChalice: avoid blockEntityRenderDispatcher.submit with new CameraRenderState() which caused JOML Matrix4fStack overflow in deeply nested GUI picture-in-picture rendering. Now renders fluid directly via WorldSharedTankCache + submitCustomGeometry. Also adds null/empty check for @Nullable itemStack parameter.
- Fix LootFunctionCopyEntangledChaliceData: add null check for fluidHandler to prevent NPE if fluid capability is not available.
- Add game test testEntangledChaliceBreakFull verifying that breaking a full chalice drops an item with the correct tank ID and fluid content.

Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>

Pull Request Pull Request #1168: Fix crash when breaking an entangled chalice full of blood

Coverage Stats

990 of 5322 branches covered (18.6%)

Branch coverage included in aggregate %.

6191 of 15323 relevant lines covered (40.4%)

1.93 hits per line