CyberShadow / aconfmgr

80%

master: 94%

LAST BUILD ON BRANCH fix-38

branch: fix-38

CHANGE BRANCH

x

Reset

• fix-38
• HEAD
• apt
• aur
• debug-find
• docker
• github-actions
• issue-templates
• master
• next
• pull-20210818-050102
• pull-20231028-131546
• pull-20231028-134617
• pull-20231029-152034
• renovate/arch-linux-base-2019.x
• renovate/arch-linux-base-2020.x
• renovate/arch-linux-base-2021.x
• renovate/arch-linux-base-2022.x
• renovate/arch-linux-base-2023.x
• renovate/arch-linux-base-2024.x
• renovate/auracle-git-20190529070325.x
• renovate/auracle-git-20190531090517.x
• renovate/auracle-git-20191215183724.x
• renovate/auracle-git-20200514063902.x
• renovate/auracle-git-20210212081255.x
• renovate/auracle-git-20210323090720.x
• renovate/auracle-git-20210529001634.x
• renovate/auracle-git-20210531192511.x
• renovate/auracle-git-20210718104550.x
• renovate/auracle-git-20211102114542.x
• renovate/auracle-git-20211109120004.x
• renovate/auracle-git-20220105184355.x
• renovate/auracle-git-20220129103039.x
• renovate/auracle-git-20220705002953.x
• renovate/auracle-git-20240313234142.x
• renovate/auracle-git-20240331220401.x
• renovate/auracle-git-20240731115314.x
• renovate/auracle-git-20240805103717.x
• renovate/auracle-git-20240817173403.x
• renovate/auracle-git-20240819053017.x
• renovate/auracle-git-20241119223955.x
• renovate/aurman-20200707213812.x
• renovate/aurman-20210619145416.x
• renovate/aurman-20230514222842.x
• renovate/configure
• renovate/pacaur-20241001224914.x
• renovate/pacaur-20241018143548.x
• renovate/package-query-20200515125902.x
• renovate/package-query-20210602170331.x
• renovate/paru-20210129213728.x
• renovate/paru-20210203234704.x
• renovate/paru-20210224112311.x
• renovate/paru-20210315113923.x
• renovate/paru-20210330131305.x
• renovate/paru-20210413211130.x
• renovate/paru-20210503133712.x
• renovate/paru-20210504063154.x
• renovate/paru-20210603030100.x
• renovate/paru-20210608145707.x
• renovate/paru-20210625185521.x
• renovate/paru-20210805104624.x
• renovate/paru-20210813135141.x
• renovate/paru-20210819154700.x
• renovate/paru-20211104010833.x
• renovate/paru-20211209231844.x
• renovate/paru-20220217095512.x
• renovate/paru-20220324201159.x
• renovate/paru-20220627160442.x
• renovate/paru-20220707091136.x
• renovate/paru-20221117101859.x
• renovate/paru-20231127034922.x
• renovate/paru-20231201221822.x
• renovate/paru-20240315204345.x
• renovate/paru-20240326042315.x
• renovate/paru-20240920025827.x
• renovate/shellcheck-0.x
• renovate/yaourt-20200914094110.x
• renovate/yay-20190406140937.x
• renovate/yay-20190620061310.x
• renovate/yay-20190920202000.x
• renovate/yay-20200114215203.x
• renovate/yay-20200117211807.x
• renovate/yay-20200227195646.x
• renovate/yay-20200501174101.x
• renovate/yay-20200614005059.x
• renovate/yay-20200618015034.x
• renovate/yay-20200628111122.x
• renovate/yay-20200720094023.x
• renovate/yay-20200818192449.x
• renovate/yay-20201018205144.x
• renovate/yay-20201117205126.x
• renovate/yay-20201214194111.x
• renovate/yay-20210129215316.x
• renovate/yay-20210317200035.x
• renovate/yay-20210412173758.x
• renovate/yay-20210510090521.x
• renovate/yay-20210520134211.x
• renovate/yay-20210603222941.x
• renovate/yay-20210729222440.x
• renovate/yay-20210821151654.x
• renovate/yay-20211009233234.x
• renovate/yay-20211010111408.x
• renovate/yay-20211016224514.x
• renovate/yay-20220102213326.x
• renovate/yay-20220206102557.x
• renovate/yay-20220306181120.x
• renovate/yay-20220617102520.x
• renovate/yay-20220814182043.x
• renovate/yay-20230915113209.x
• renovate/yay-20231130094145.x
• renovate/yay-20240219172718.x
• renovate/yay-20240305115926.x
• renovate/yay-20240313164928.x
• renovate/yay-20240316013525.x
• renovate/yay-20240317162829.x
• renovate/yay-20240323235419.x
• renovate/yay-20240914182501.x
• renovate/yay-20240917175330.x
• renovate/yay-20240919162649.x
• revert-yes-piping
• svg-screenshot
• testsuite

Build # 127

Build Type

Pull #39

travis-ci

Committed by web-flow

Commit Message

Fix adding, then removing a directory

If a directory containing files was present in the configuration but
not the system, aconfmgr would emit RemoveFile commands for the
directory, and then its containing files. This would fail due to
`rm` (issued by RemoveFile) failing to remove a directory.

Fix this by:

1. Reversing the order that configuration-only files are iterated over
   when emitting RemoveFile commands. This should ensure that child
   filesystem objects are removed before their containing directories.

2. Invoking `rm` with `--dir` from RemoveFile, thus allowing the
   removal of emptied directories. (Use `--dir` instead of
   `--recursive`, as the latter should be excessive.)

Fixes #38.

Pull Request Pull Request #39: Fix #38

Run Details

122 of 122 new or added lines in 9 files covered. (100.0%)

1921 of 2387 relevant lines covered (80.48%)

315.49 hits per line