CZ-NIC / knot-resolver

68%

master: 68%

LAST BUILD ON BRANCH layer-api

branch: layer-api

CHANGE BRANCH

x

Reset

• layer-api
• 1.0-beta
• 1.0.0-beta1
• 1.2.0-dev
• add_libedit
• add_libedit_2
• allow_to_set_hostname
• amalg-build
• async-io-requests
• better-rtt-tracking
• bootstrap-speed
• build-improvements
• build-libkresd-with-soversion
• cache-api-v2
• cache-memcached
• cache-purging-fixes
• cache-redis-wip
• cache-reuse-txns
• cache-rrsig-wip
• cache_test_fix
• cd_proc
• cd_proc_new
• cd_processing
• clean-tests
• cname-strict-refetch
• cname_fix
• cname_rrsig
• contrib-embed-libknot
• cookies-wip
• coverity-fix
• coverity_scan
• debug-fixup
• deck_test
• deckard
• deckard-enobuf
• dns-oarc
• dns64
• doc-forward-doesnt-validate
• dont-fragment-mtu
• ds-chain-fix
• dups
• dynamic-soversion
• early_awareness_notification
• embed-deckard
• empty-sfail
• empty-sfail-next
• ent-wc-fix
• fast-retransmit
• faster-request-proc
• favour-ipv4
• fix-ns-badboys
• fix-pktcache
• fix-rare-crash
• fix-segfault-in-early-quit
• fix-tests
• forward-perf
• gitignore-update
• gitlab-ci
• golang-modules
• golang-more-arch
• hints.del
• hive-wip
• http-fixup
• http-server
• improve-lmdb-info
• improve-version.mk
• inbound-deduping
• include_cleanup
• integration_tests_wip
• keytag-filter
• kr_cache_insert_lowmem
• kr_layer
• lru-alias-warn
• lua-bytecode
• lua-embed-bytecode
• lua-fastcall
• lua-ffi-structs
• lua-gen-cdefs
• lua-http-0.1
• lua-kr_rplan_pop
• marek/bugfixes
• master
• mod-daf-after-http
• new-libknot
• new-root-hints
• news
• nitpicks
• nlogdebug
• ns-rtt-cache
• nstimeout-bug
• omnia
• osx-cache
• osx-sed
• osx-uint
• p/lru-rebased
• p/net.listen
• p/reorder
• pktcache-fix
• policy
• prefer-ipv6-nsrep
• prefetch-wip
• prefix-sbindir-changes
• r2u_fix
• r2u_fix_clear
• r_preselect
• ref2unsign
• ref_serv
• refs
• rel_cleanup
• remove-bashisms
• resolve_example_in_documentation
• respdiff
• resumable-layers
• root-hints-regeneration
• round-robin
• rrcache-fix
• rrcache_fix
• rtd-fix
• scrub-dnssec
• stats-module
• stubmode
• subreq-deduping
• supervisor
• sysd-socket-act
• tcp-ooo
• tcp-ooo-ref_serv
• test-script
• test_binary
• test_cache
• test_cache_fix
• test_cache_global_api
• test_cache_materialize
• tests
• tests_raw_query
• tests_wrapped
• tls-listen
• tls_padding
• touched_map
• travis-build-fix
• travis-darwin-check
• travis-fix
• travis-osx-fix
• travis-ubuntu-trusty
• typedef-uint
• update-gitignore
• v1.0.0
• v1.0.0-beta1
• v1.0.0-beta2
• v1.0.0-beta3
• v1.1.0
• v1.1.0-omnia
• v1.1.1
• validate-fix-pc-unsigned
• verbose-fixups
• verboselog
• vld-fix
• vld-refactoring
• vld_new
• worker-uninit
• ws_fix
• wsheet-vld-wip
• zonecut-membug

Build # 1352

Build Type

push

travis-ci

Committed by vcunat

Commit Message

layer: refactor and better describe the API

- The API and ABI for modules changes slightly (details below).
  KR_MODULE_API is bumped to avoid loading incompatible code.
  We have bumped libkres ABIVER since the last release 1.1.1,
  so leaving that one intact.

- Make KR_STATE_YIELD not reuse 0 value anymore.
  It's easy to e.g. return kr_ok() by mistake.
- struct kr_layer_t:
  * ::mm was unused, uninitialized, etc.
  * Make ::state an int, as it was everywhere else.
  * void *data was ugly and always containing struct kr_request *
- struct kr_layer_api:
  * Drop the void* parameter from ::begin, as it was only used
    for the request which is available as ctx->req anyway
    (formerly ctx->data).
  * Drop ::fail.  It wasn't even called.  Modules can watch for
    KR_STATE_FAIL in ::finish.
- Document the apparent meaning of the layer interface, deduced mainly
  from the way it's used in the code.  Caveats:
  * enum knot_layer_state handling seems to assume that it holds exactly
    one of the possibilities at a time.  The cookie module does NOT
    follow that (intentionally), apparently depending on the exact
    implementation of the handling at that moment.  It feels fragile.
  * I was unable to deduce a plausible description of when ::reset is
    called.  It's practically unused in modules, too.

Run Details

21 of 21 new or added lines in 6 files covered. (100.0%)

5194 of 7601 relevant lines covered (68.33%)

25585.1 hits per line